[v1,1/5] board/armadeus: replace utf-8 graphic sympols by ascii characters
diff mbox series

Message ID 20190508172822.7929-1-ps.report@gmx.net
State Accepted
Headers show
Series
  • [v1,1/5] board/armadeus: replace utf-8 graphic sympols by ascii characters
Related show

Commit Message

Peter Seiderer May 8, 2019, 5:28 p.m. UTC
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 board/armadeus/readme.txt | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

--
2.21.0

Comments

Thomas Petazzoni May 18, 2019, 9:36 p.m. UTC | #1
On Wed,  8 May 2019 19:28:18 +0200
Peter Seiderer <ps.report@gmx.net> wrote:

> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  board/armadeus/readme.txt | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Series applied to master. Thanks!

Thomas
Yann E. MORIN May 19, 2019, 9:08 a.m. UTC | #2
Peter, Thomas, Peter, All,

On 2019-05-18 23:36 +0200, Thomas Petazzoni spake thusly:
> On Wed,  8 May 2019 19:28:18 +0200
> Peter Seiderer <ps.report@gmx.net> wrote:
> 
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> >  board/armadeus/readme.txt | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> Series applied to master. Thanks!

Sorry, but I still fail to see why we want to remove non-ascii chars,
especially in docs and the likes. The commit logs for these patches fail
to explain the problem they fix, if there is even a problem.

This whole "no UTF-8 chars patches" are totally nonsense nowadays. If
your system still can't display them properly, upgrade and get a decent
font.

Now, if I need to add a comment like:

    # As explained by Frédéric in [0], blurb da dee woops blabla...

then, check-package whines. While "Frédéric" can be easily asciified to
Frederic, this is not nice and there are a lot of names that can't be
easily asciified, like 李金福 or anyone whose language is not using a
latin script.

I agree that the unicode NO-BREAK-SPACE (U+00A0, UTF-8 C2A0) is nasty,
and should be replaced, but otherwise it feels like we're going
something like 30 years back in time...

BTW, a good editor can be made to report such "trolling" chars. For
example, there is a plugin for vim that can highlight such chars, like
NO-BREAK-SPACE " " (U+00A0) which is highlighted red for me here:
    https://github.com/vim-utils/vim-troll-stopper
And for emacs (untested, I don't use emacs):
    https://www.emacswiki.org/emacs/highlight-chars.el

Regards,
Yann E. MORIN.

PS. Yes, I was the first one to report and fix U+00A0 (C2 A0) in
    5d436ac5a6 and 911ac036e0, but those were fixing real problems.
YEM.
Peter Seiderer May 19, 2019, 9:42 p.m. UTC | #3
Hello Yann, and *,

On Sun, 19 May 2019 11:08:53 +0200, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Peter, Thomas, Peter, All,
> 
> On 2019-05-18 23:36 +0200, Thomas Petazzoni spake thusly:
> > On Wed,  8 May 2019 19:28:18 +0200
> > Peter Seiderer <ps.report@gmx.net> wrote:
> >   
> > > Signed-off-by: Peter Seiderer <ps.report@gmx.net>--cc "Ricardo Martincoski <ricardo.martincoski@gmail.com>"
> > > ---
> > >  board/armadeus/readme.txt | 10 +++++-----
> > >  1 file changed, 5 insertions(+), 5 deletions(-)  
> > 
> > Series applied to master. Thanks!  
> 
> Sorry, but I still fail to see why we want to remove non-ascii chars,
> especially in docs and the likes. The commit logs for these patches fail
> to explain the problem they fix, if there is even a problem.

Valid point, maybe for the board patches a commit tile a la 'harmonize graphic
symbol usage' would have been better...

> 
> This whole "no UTF-8 chars patches" are totally nonsense nowadays. If
> your system still can't display them properly, upgrade and get a decent
> font.
> 
> Now, if I need to add a comment like:
> 
>     # As explained by Frédéric in [0], blurb da dee woops blabla...
> 
> then, check-package whines. While "Frédéric" can be easily asciified to
> Frederic, this is not nice and there are a lot of names that can't be
> easily asciified, like 李金福 or anyone whose language is not using a
> latin script.
> 
> I agree that the unicode NO-BREAK-SPACE (U+00A0, UTF-8 C2A0) is nasty,
> and should be replaced, but otherwise it feels like we're going
> something like 30 years back in time...

Yes, Frédéric will surly by honoured to be called by his real name ;-),
but all package patches touched easily replaceable UTF-8 characters
and did not change, by intent, the ones mentioned by Peter Korsgaard
(see [1]) and Arnout Vandecappelle mentioned the From/Sob tags
problem (see [2])...

> 
> BTW, a good editor can be made to report such "trolling" chars. For
> example, there is a plugin for vim that can highlight such chars, like
> NO-BREAK-SPACE " " (U+00A0) which is highlighted red for me here:
>     https://github.com/vim-utils/vim-troll-stopper
> And for emacs (untested, I don't use emacs):
>     https://www.emacswiki.org/emacs/highlight-chars.el

It is simpler to check for not utf-8 instead of an blacklist of
various characters (no-break-space, multiple quote/hyphen signs, etc.),
maybe the warning can be downgraded to a minor one (plus a hint 'do
not apply to names')...

Regards,
Peter

[1] http://lists.busybox.net/pipermail/buildroot/2019-May/249725.html
[2] http://lists.busybox.net/pipermail/buildroot/2019-May/249716.html

> 
> Regards,
> Yann E. MORIN.
> 
> PS. Yes, I was the first one to report and fix U+00A0 (C2 A0) in
>     5d436ac5a6 and 911ac036e0, but those were fixing real problems.
> YEM.
>

Patch
diff mbox series

diff --git a/board/armadeus/readme.txt b/board/armadeus/readme.txt
index 98c7b08249..c03508c604 100644
--- a/board/armadeus/readme.txt
+++ b/board/armadeus/readme.txt
@@ -44,11 +44,11 @@  Result of the build
 When the build is finished, you will end up with:

     output/images/
-    ├── imx**-apfxxdev.dtb	[1]
-    ├── rootfs.tar
-    ├── rootfs.ubi
-    ├── rootfs.ubifs
-    └── uImage
+    +-- imx**-apfxxdev.dtb	[1]
+    +-- rootfs.tar
+    +-- rootfs.ubi
+    +-- rootfs.ubifs
+    +-- uImage

 [1] Only if the kernel version used uses a Device Tree.