| Message ID | 20190508105135.13170-1-colin.king@canonical.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: hns3: remove redundant assignment of l2_hdr to itself | expand |
On 2019/5/8 18:51, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The pointer l2_hdr is being assigned to itself, this is redundant > and can be removed. > > Addresses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > index 18711e0f9bdf..196a3d780dcf 100644 > --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > @@ -810,7 +810,7 @@ static int hns3_set_l2l3l4(struct sk_buff *skb, u8 ol4_proto, > u8 il4_proto, u32 *type_cs_vlan_tso, > u32 *ol_type_vlan_len_msec) > { > - unsigned char *l2_hdr = l2_hdr = skb->data; > + unsigned char *l2_hdr = skb->data; Reviewed-by: Yunsheng Lin <linyunsheng@huawei.com> Thanks. > u32 l4_proto = ol4_proto; > union l4_hdr_info l4; > union l3_hdr_info l3; >
From: Colin King <colin.king@canonical.com> Date: Wed, 8 May 2019 11:51:35 +0100 > From: Colin Ian King <colin.king@canonical.com> > > The pointer l2_hdr is being assigned to itself, this is redundant > and can be removed. > > Addresses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied.
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index 18711e0f9bdf..196a3d780dcf 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -810,7 +810,7 @@ static int hns3_set_l2l3l4(struct sk_buff *skb, u8 ol4_proto, u8 il4_proto, u32 *type_cs_vlan_tso, u32 *ol_type_vlan_len_msec) { - unsigned char *l2_hdr = l2_hdr = skb->data; + unsigned char *l2_hdr = skb->data; u32 l4_proto = ol4_proto; union l4_hdr_info l4; union l3_hdr_info l3;