[V2,8/9] support/config.sub: Add C-SKY support
diff mbox series

Message ID 1557305915-11247-8-git-send-email-guoren@kernel.org
State Accepted
Headers show
Series
  • [V2,1/9] arch/csky: Add VDSP and FLOAT_ABI compiler options.
Related show

Commit Message

Guo Ren May 8, 2019, 8:58 a.m. UTC
From: Guo Ren <ren_guo@c-sky.com>

Enable gnuconfig for C-SKY Architecutre compiling.

Signed-off-by: Guo Ren <ren_guo@c-sky.com>
---
 support/gnuconfig/config.sub | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Petazzoni May 27, 2019, 8:30 p.m. UTC | #1
Hello Guo,

On Wed,  8 May 2019 16:58:34 +0800
guoren@kernel.org wrote:

> From: Guo Ren <ren_guo@c-sky.com>
> 
> Enable gnuconfig for C-SKY Architecutre compiling.
> 
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> ---
>  support/gnuconfig/config.sub | 2 ++
>  1 file changed, 2 insertions(+)

I've slightly improved the commit message, and applied to master. I've
applied to master and not to next, because this commit is really
important: without it, none of the autotools based packages can build
on C-SKY (which is not yet tested in the autobuilders).

Best regards,

Thomas
Peter Korsgaard May 27, 2019, 10 p.m. UTC | #2
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello Guo,
 > On Wed,  8 May 2019 16:58:34 +0800
 > guoren@kernel.org wrote:

 >> From: Guo Ren <ren_guo@c-sky.com>
 >> 
 >> Enable gnuconfig for C-SKY Architecutre compiling.
 >> 
 >> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
 >> ---
 >> support/gnuconfig/config.sub | 2 ++
 >> 1 file changed, 2 insertions(+)

 > I've slightly improved the commit message, and applied to master. I've
 > applied to master and not to next, because this commit is really
 > important: without it, none of the autotools based packages can build
 > on C-SKY (which is not yet tested in the autobuilders).

I agree that this minimal change is probably the most sensible thing to
do for master, but for next it IMHO makes more sense to update our
config.sub / config.guess copies, as upstream has gained csky support
since:

commit 63b4ce2e8c28aee6a32133e400436e4ca885215a
Author: Mao Han <han_mao@c-sky.com>
Date:   Mon Apr 16 14:46:36 2018 +1000

           * config.sub (csky, csky-*): Recognise.
           * testsuite/config-sub.data: Add a test case.

   Signed-off-by: Ben Elliston <bje@gnu.org>
Thomas Petazzoni May 28, 2019, 6:55 a.m. UTC | #3
Hello,

On Tue, 28 May 2019 00:00:35 +0200
Peter Korsgaard <peter@korsgaard.com> wrote:

> I agree that this minimal change is probably the most sensible thing to
> do for master, but for next it IMHO makes more sense to update our
> config.sub / config.guess copies, as upstream has gained csky support
> since:
> 
> commit 63b4ce2e8c28aee6a32133e400436e4ca885215a
> Author: Mao Han <han_mao@c-sky.com>
> Date:   Mon Apr 16 14:46:36 2018 +1000
> 
>            * config.sub (csky, csky-*): Recognise.
>            * testsuite/config-sub.data: Add a test case.
> 
>    Signed-off-by: Ben Elliston <bje@gnu.org>

Agreed. I hadn't checked upstream gnuconfig, but it indeed makes a lot
of sense to update our gnuconfig copy using the latest upstream version.

Best regards,

Thomas
Peter Korsgaard June 6, 2019, 3:19 p.m. UTC | #4
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > Hello Guo,
 > On Wed,  8 May 2019 16:58:34 +0800
 > guoren@kernel.org wrote:

 >> From: Guo Ren <ren_guo@c-sky.com>
 >> 
 >> Enable gnuconfig for C-SKY Architecutre compiling.
 >> 
 >> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
 >> ---
 >> support/gnuconfig/config.sub | 2 ++
 >> 1 file changed, 2 insertions(+)

 > I've slightly improved the commit message, and applied to master. I've
 > applied to master and not to next, because this commit is really
 > important: without it, none of the autotools based packages can build
 > on C-SKY (which is not yet tested in the autobuilders).

Committed to 2019.02.x, thanks.

Patch
diff mbox series

diff --git a/support/gnuconfig/config.sub b/support/gnuconfig/config.sub
index 6d86a1e..45dd0a7 100755
--- a/support/gnuconfig/config.sub
+++ b/support/gnuconfig/config.sub
@@ -254,6 +254,7 @@  case $basic_machine in
 	| arc | arceb \
 	| arm | arm[bl]e | arme[lb] | armv[2-8] | armv[3-8][lb] | armv7[arm] \
 	| avr | avr32 \
+	| csky \
 	| ba \
 	| be32 | be64 \
 	| bfin \
@@ -376,6 +377,7 @@  case $basic_machine in
 	| alphapca5[67]-* | alpha64pca5[67]-* | arc-* | arceb-* \
 	| arm-*  | armbe-* | armle-* | armeb-* | armv*-* \
 	| avr-* | avr32-* \
+	| csky-* \
 	| ba-* \
 	| be32-* | be64-* \
 	| bfin-* | bs2000-* \