From patchwork Thu Aug 11 14:25:00 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: holt@sgi.com
X-Patchwork-Id: 109613
X-Patchwork-Delegate: galak@kernel.crashing.org
Return-Path: 
 <linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org>
X-Original-To: patchwork-incoming@ozlabs.org
Delivered-To: patchwork-incoming@ozlabs.org
Received: from ozlabs.org (localhost [IPv6:::1])
	by ozlabs.org (Postfix) with ESMTP id 90399B748A
	for <patchwork-incoming@ozlabs.org>;
	Fri, 12 Aug 2011 00:25:11 +1000 (EST)
Received: from relay.sgi.com (relay3.sgi.com [192.48.152.1])
	by ozlabs.org (Postfix) with ESMTP id C21DAB6F80
	for <linuxppc-dev@lists.ozlabs.org>;
	Fri, 12 Aug 2011 00:25:03 +1000 (EST)
Received: from estes.americas.sgi.com (estes.americas.sgi.com
	[128.162.236.10])
	by relay3.corp.sgi.com (Postfix) with ESMTP id 6F35EAC003;
	Thu, 11 Aug 2011 07:25:01 -0700 (PDT)
Received: from lnx-holt.americas.sgi.com (lnx-holt.americas.sgi.com
	[128.162.233.109])
	by estes.americas.sgi.com (Postfix) with ESMTP id 24DFD70001D6;
	Thu, 11 Aug 2011 09:25:01 -0500 (CDT)
Received: from holt by lnx-holt.americas.sgi.com with local (Exim 4.71)
	(envelope-from <holt@sgi.com>)
	id 1QrWBx-0006cT-3g; Thu, 11 Aug 2011 09:25:01 -0500
Date: Thu, 11 Aug 2011 09:25:00 -0500
From: Robin Holt <holt@sgi.com>
To: U Bhaskar-B22300 <B22300@freescale.com>
Subject: [PATCH] p1010rdb: gianfar config does not have queues.
Message-ID: <20110811142500.GD4926@sgi.com>
MIME-Version: 1.0
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: PPC list <linuxppc-dev@lists.ozlabs.org>,
	Eric Dumazet <eric.dumazet@gmail.com>
X-BeenThere: linuxppc-dev@lists.ozlabs.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Linux on PowerPC Developers Mail List
	<linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>
Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org
Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org

If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties
defined in the p1010's device tree file, I get a kernel panic very
shortly after boot.  The failure indicates we are configuring the
gianfar.c driver for a queue depth greater than actual.  Removing the
properties got the problem resolved.

Signed-off-by: Robin Holt <holt@sgi.com>
To: U Bhaskar-B22300 <B22300@freescale.com>
Cc: PPC list <linuxppc-dev@lists.ozlabs.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>

diff --git a/arch/powerpc/boot/dts/p1010si.dtsi b/arch/powerpc/boot/dts/p1010si.dtsi
index 7f51104..91566aa 100644
--- a/arch/powerpc/boot/dts/p1010si.dtsi
+++ b/arch/powerpc/boot/dts/p1010si.dtsi
@@ -258,8 +258,6 @@
 			device_type = "network";
 			model = "eTSEC";
 			compatible = "fsl,etsec2";
-			fsl,num_rx_queues = <0x8>;
-			fsl,num_tx_queues = <0x8>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;
 
@@ -280,8 +278,6 @@
 			device_type = "network";
 			model = "eTSEC";
 			compatible = "fsl,etsec2";
-			fsl,num_rx_queues = <0x8>;
-			fsl,num_tx_queues = <0x8>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;
 
@@ -302,8 +298,6 @@
 			device_type = "network";
 			model = "eTSEC";
 			compatible = "fsl,etsec2";
-			fsl,num_rx_queues = <0x8>;
-			fsl,num_tx_queues = <0x8>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;