Patchwork p1010rdb: gianfar config does not have queues.

login
register
mail settings
Submitter holt@sgi.com
Date Aug. 11, 2011, 2:25 p.m.
Message ID <20110811142500.GD4926@sgi.com>
Download mbox | patch
Permalink /patch/109613/
State Superseded
Delegated to: Kumar Gala
Headers show

Comments

holt@sgi.com - Aug. 11, 2011, 2:25 p.m.
If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties
defined in the p1010's device tree file, I get a kernel panic very
shortly after boot.  The failure indicates we are configuring the
gianfar.c driver for a queue depth greater than actual.  Removing the
properties got the problem resolved.

Signed-off-by: Robin Holt <holt@sgi.com>
To: U Bhaskar-B22300 <B22300@freescale.com>
Cc: PPC list <linuxppc-dev@lists.ozlabs.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Kumar Gala - March 16, 2012, 3:20 p.m.
On Aug 11, 2011, at 9:25 AM, Robin Holt wrote:

> If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties
> defined in the p1010's device tree file, I get a kernel panic very
> shortly after boot.  The failure indicates we are configuring the
> gianfar.c driver for a queue depth greater than actual.  Removing the
> properties got the problem resolved.
> 
> Signed-off-by: Robin Holt <holt@sgi.com>
> To: U Bhaskar-B22300 <B22300@freescale.com>
> Cc: PPC list <linuxppc-dev@lists.ozlabs.org>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>

Poonam,

Can you comment on this patch, does it look correct?

- k

> 
> diff --git a/arch/powerpc/boot/dts/p1010si.dtsi b/arch/powerpc/boot/dts/p1010si.dtsi
> index 7f51104..91566aa 100644
> --- a/arch/powerpc/boot/dts/p1010si.dtsi
> +++ b/arch/powerpc/boot/dts/p1010si.dtsi
> @@ -258,8 +258,6 @@
> 			device_type = "network";
> 			model = "eTSEC";
> 			compatible = "fsl,etsec2";
> -			fsl,num_rx_queues = <0x8>;
> -			fsl,num_tx_queues = <0x8>;
> 			local-mac-address = [ 00 00 00 00 00 00 ];
> 			interrupt-parent = <&mpic>;
> 
> @@ -280,8 +278,6 @@
> 			device_type = "network";
> 			model = "eTSEC";
> 			compatible = "fsl,etsec2";
> -			fsl,num_rx_queues = <0x8>;
> -			fsl,num_tx_queues = <0x8>;
> 			local-mac-address = [ 00 00 00 00 00 00 ];
> 			interrupt-parent = <&mpic>;
> 
> @@ -302,8 +298,6 @@
> 			device_type = "network";
> 			model = "eTSEC";
> 			compatible = "fsl,etsec2";
> -			fsl,num_rx_queues = <0x8>;
> -			fsl,num_tx_queues = <0x8>;
> 			local-mac-address = [ 00 00 00 00 00 00 ];
> 			interrupt-parent = <&mpic>;
> 
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
Aggrwal Poonam-B10812 - March 17, 2012, 5:37 a.m.
Hello Pankaj, Rajan

DO you have any comments on the below patch of gianfar?
> > -			fsl,num_rx_queues = <0x8>;
> > -			fsl,num_tx_queues = <0x8>;
Have been removed from P1010RDB device tree to avoid a kernel panic.

Kumar, as such I see this is the old dts format. Also in the latest sdk tree these properties are defined, not sure it is working on P1010RDB.
I can check on this and get back.


Regards
Poonam

> -----Original Message-----
> From: Kumar Gala [mailto:galak@kernel.crashing.org]
> Sent: Friday, March 16, 2012 8:50 PM
> To: Aggrwal Poonam-B10812
> Cc: Robin Holt; U Bhaskar-B22300; PPC list; Eric Dumazet
> Subject: Re: [PATCH] p1010rdb: gianfar config does not have queues.
> 
> 
> On Aug 11, 2011, at 9:25 AM, Robin Holt wrote:
> 
> > If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties
> > defined in the p1010's device tree file, I get a kernel panic very
> > shortly after boot.  The failure indicates we are configuring the
> > gianfar.c driver for a queue depth greater than actual.  Removing the
> > properties got the problem resolved.
> >
> > Signed-off-by: Robin Holt <holt@sgi.com>
> > To: U Bhaskar-B22300 <B22300@freescale.com>
> > Cc: PPC list <linuxppc-dev@lists.ozlabs.org>
> > Cc: Eric Dumazet <eric.dumazet@gmail.com>
> 
> Poonam,
> 
> Can you comment on this patch, does it look correct?
> 
> - k
> 
> >
> > diff --git a/arch/powerpc/boot/dts/p1010si.dtsi
> > b/arch/powerpc/boot/dts/p1010si.dtsi
> > index 7f51104..91566aa 100644
> > --- a/arch/powerpc/boot/dts/p1010si.dtsi
> > +++ b/arch/powerpc/boot/dts/p1010si.dtsi
> > @@ -258,8 +258,6 @@
> > 			device_type = "network";
> > 			model = "eTSEC";
> > 			compatible = "fsl,etsec2";
> > -			fsl,num_rx_queues = <0x8>;
> > -			fsl,num_tx_queues = <0x8>;
> > 			local-mac-address = [ 00 00 00 00 00 00 ];
> > 			interrupt-parent = <&mpic>;
> >
> > @@ -280,8 +278,6 @@
> > 			device_type = "network";
> > 			model = "eTSEC";
> > 			compatible = "fsl,etsec2";
> > -			fsl,num_rx_queues = <0x8>;
> > -			fsl,num_tx_queues = <0x8>;
> > 			local-mac-address = [ 00 00 00 00 00 00 ];
> > 			interrupt-parent = <&mpic>;
> >
> > @@ -302,8 +298,6 @@
> > 			device_type = "network";
> > 			model = "eTSEC";
> > 			compatible = "fsl,etsec2";
> > -			fsl,num_rx_queues = <0x8>;
> > -			fsl,num_tx_queues = <0x8>;
> > 			local-mac-address = [ 00 00 00 00 00 00 ];
> > 			interrupt-parent = <&mpic>;
> >
> > _______________________________________________
> > Linuxppc-dev mailing list
> > Linuxppc-dev@lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/linuxppc-dev
>
Kumar Gala - March 21, 2012, 3:26 p.m.
On Mar 17, 2012, at 12:37 AM, Aggrwal Poonam-B10812 wrote:

> Hello Pankaj, Rajan
> 
> DO you have any comments on the below patch of gianfar?
>>> -			fsl,num_rx_queues = <0x8>;
>>> -			fsl,num_tx_queues = <0x8>;
> Have been removed from P1010RDB device tree to avoid a kernel panic.
> 

Ah, right.

> Kumar, as such I see this is the old dts format. Also in the latest sdk tree these properties are defined, not sure it is working on P1010RDB.
> I can check on this and get back.

Mostly, can you check that p1010rdb boots and works w/my next branch.

- k

> 
> 
> Regards
> Poonam
> 
>> -----Original Message-----
>> From: Kumar Gala [mailto:galak@kernel.crashing.org]
>> Sent: Friday, March 16, 2012 8:50 PM
>> To: Aggrwal Poonam-B10812
>> Cc: Robin Holt; U Bhaskar-B22300; PPC list; Eric Dumazet
>> Subject: Re: [PATCH] p1010rdb: gianfar config does not have queues.
>> 
>> 
>> On Aug 11, 2011, at 9:25 AM, Robin Holt wrote:
>> 
>>> If I have the the fsl,num_rx_queues and fsl,num_tx_queues properties
>>> defined in the p1010's device tree file, I get a kernel panic very
>>> shortly after boot.  The failure indicates we are configuring the
>>> gianfar.c driver for a queue depth greater than actual.  Removing the
>>> properties got the problem resolved.
>>> 
>>> Signed-off-by: Robin Holt <holt@sgi.com>
>>> To: U Bhaskar-B22300 <B22300@freescale.com>
>>> Cc: PPC list <linuxppc-dev@lists.ozlabs.org>
>>> Cc: Eric Dumazet <eric.dumazet@gmail.com>
>> 
>> Poonam,
>> 
>> Can you comment on this patch, does it look correct?
>> 
>> - k
>> 
>>> 
>>> diff --git a/arch/powerpc/boot/dts/p1010si.dtsi
>>> b/arch/powerpc/boot/dts/p1010si.dtsi
>>> index 7f51104..91566aa 100644
>>> --- a/arch/powerpc/boot/dts/p1010si.dtsi
>>> +++ b/arch/powerpc/boot/dts/p1010si.dtsi
>>> @@ -258,8 +258,6 @@
>>> 			device_type = "network";
>>> 			model = "eTSEC";
>>> 			compatible = "fsl,etsec2";
>>> -			fsl,num_rx_queues = <0x8>;
>>> -			fsl,num_tx_queues = <0x8>;
>>> 			local-mac-address = [ 00 00 00 00 00 00 ];
>>> 			interrupt-parent = <&mpic>;
>>> 
>>> @@ -280,8 +278,6 @@
>>> 			device_type = "network";
>>> 			model = "eTSEC";
>>> 			compatible = "fsl,etsec2";
>>> -			fsl,num_rx_queues = <0x8>;
>>> -			fsl,num_tx_queues = <0x8>;
>>> 			local-mac-address = [ 00 00 00 00 00 00 ];
>>> 			interrupt-parent = <&mpic>;
>>> 
>>> @@ -302,8 +298,6 @@
>>> 			device_type = "network";
>>> 			model = "eTSEC";
>>> 			compatible = "fsl,etsec2";
>>> -			fsl,num_rx_queues = <0x8>;
>>> -			fsl,num_tx_queues = <0x8>;
>>> 			local-mac-address = [ 00 00 00 00 00 00 ];
>>> 			interrupt-parent = <&mpic>;
>>> 
>>> _______________________________________________
>>> Linuxppc-dev mailing list
>>> Linuxppc-dev@lists.ozlabs.org
>>> https://lists.ozlabs.org/listinfo/linuxppc-dev
>> 
>

Patch

diff --git a/arch/powerpc/boot/dts/p1010si.dtsi b/arch/powerpc/boot/dts/p1010si.dtsi
index 7f51104..91566aa 100644
--- a/arch/powerpc/boot/dts/p1010si.dtsi
+++ b/arch/powerpc/boot/dts/p1010si.dtsi
@@ -258,8 +258,6 @@ 
 			device_type = "network";
 			model = "eTSEC";
 			compatible = "fsl,etsec2";
-			fsl,num_rx_queues = <0x8>;
-			fsl,num_tx_queues = <0x8>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;
 
@@ -280,8 +278,6 @@ 
 			device_type = "network";
 			model = "eTSEC";
 			compatible = "fsl,etsec2";
-			fsl,num_rx_queues = <0x8>;
-			fsl,num_tx_queues = <0x8>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;
 
@@ -302,8 +298,6 @@ 
 			device_type = "network";
 			model = "eTSEC";
 			compatible = "fsl,etsec2";
-			fsl,num_rx_queues = <0x8>;
-			fsl,num_tx_queues = <0x8>;
 			local-mac-address = [ 00 00 00 00 00 00 ];
 			interrupt-parent = <&mpic>;