[SRU,B/OEM-B/C/D,1/1] ALSA: hda/realtek - Fixed Dell AIO speaker noise
diff mbox series

Message ID 20190507035831.8192-2-hui.wang@canonical.com
State New
Headers show
Series
  • The noise keeps occurring when Headset is plugged in on a Dell machine
Related show

Commit Message

Hui Wang May 7, 2019, 3:58 a.m. UTC
From: Kailang Yang <kailang@realtek.com>

BugLink: https://bugs.launchpad.net/bugs/1827972

Fixed Dell AIO speaker noise.
spec->gen.auto_mute_via_amp = 1, this option was solved speaker white
noise at boot.
codec->power_save_node = 0, this option was solved speaker noise at
resume back.

Fixes: 9226665159f0 ("ALSA: hda/realtek - Fix Dell AIO LineOut issue")
Signed-off-by: Kailang Yang <kailang@realtek.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit 0700d3d117a7f110ddddbd83873e13652f69c54b)
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Kleber Souza May 7, 2019, 12:37 p.m. UTC | #1
On 5/7/19 5:58 AM, Hui Wang wrote:
> From: Kailang Yang <kailang@realtek.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1827972
> 
> Fixed Dell AIO speaker noise.
> spec->gen.auto_mute_via_amp = 1, this option was solved speaker white
> noise at boot.
> codec->power_save_node = 0, this option was solved speaker noise at
> resume back.
> 
> Fixes: 9226665159f0 ("ALSA: hda/realtek - Fix Dell AIO LineOut issue")
> Signed-off-by: Kailang Yang <kailang@realtek.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit 0700d3d117a7f110ddddbd83873e13652f69c54b)
> Signed-off-by: Hui Wang <hui.wang@canonical.com>

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>  sound/pci/hda/patch_realtek.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index e1285808c5a0..79a8b76106a9 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5409,6 +5409,8 @@ static void alc274_fixup_bind_dacs(struct hda_codec *codec,
>  		return;
>  
>  	spec->gen.preferred_dacs = preferred_pairs;
> +	spec->gen.auto_mute_via_amp = 1;
> +	codec->power_save_node = 0;
>  }
>  
>  /* The DAC of NID 0x3 will introduce click/pop noise on headphones, so invalidate it */
>
Connor Kuehl May 8, 2019, 5:44 p.m. UTC | #2
On 5/6/19 8:58 PM, Hui Wang wrote:
> From: Kailang Yang <kailang@realtek.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1827972
> 
> Fixed Dell AIO speaker noise.
> spec->gen.auto_mute_via_amp = 1, this option was solved speaker white
> noise at boot.
> codec->power_save_node = 0, this option was solved speaker noise at
> resume back.
> 
> Fixes: 9226665159f0 ("ALSA: hda/realtek - Fix Dell AIO LineOut issue")
> Signed-off-by: Kailang Yang <kailang@realtek.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit 0700d3d117a7f110ddddbd83873e13652f69c54b)
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---

Acked-by: Connor Kuehl <connor.kuehl@canonical.com>

>  sound/pci/hda/patch_realtek.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index e1285808c5a0..79a8b76106a9 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5409,6 +5409,8 @@ static void alc274_fixup_bind_dacs(struct hda_codec *codec,
>  		return;
>  
>  	spec->gen.preferred_dacs = preferred_pairs;
> +	spec->gen.auto_mute_via_amp = 1;
> +	codec->power_save_node = 0;
>  }
>  
>  /* The DAC of NID 0x3 will introduce click/pop noise on headphones, so invalidate it */
>

Patch
diff mbox series

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e1285808c5a0..79a8b76106a9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5409,6 +5409,8 @@  static void alc274_fixup_bind_dacs(struct hda_codec *codec,
 		return;
 
 	spec->gen.preferred_dacs = preferred_pairs;
+	spec->gen.auto_mute_via_amp = 1;
+	codec->power_save_node = 0;
 }
 
 /* The DAC of NID 0x3 will introduce click/pop noise on headphones, so invalidate it */