| Message ID | 3d79b143-70e7-2345-dcca-53967339b1d1@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] r8169: make use of phy_set_asym_pause | expand |
From: Heiner Kallweit <hkallweit1@gmail.com> Date: Sat, 4 May 2019 12:01:03 +0200 > phy_probe() takes care that all supported modes are advertised, > in addition use phy_support_asym_pause() to advertise pause modes. > This way we don't have to deal with phylib internals directly. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Applied, thanks.
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index ee16b7782..ad2ebb367 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -6459,8 +6459,7 @@ static int r8169_phy_connect(struct rtl8169_private *tp) if (!tp->supports_gmii) phy_set_max_speed(phydev, SPEED_100); - /* Ensure to advertise everything, incl. pause */ - linkmode_copy(phydev->advertising, phydev->supported); + phy_support_asym_pause(phydev); phy_attached_info(phydev);
phy_probe() takes care that all supported modes are advertised, in addition use phy_support_asym_pause() to advertise pause modes. This way we don't have to deal with phylib internals directly. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)