diff mbox series

[net-next] netdevsim: Make nsim_num_vf static

Message ID 20190504081207.22764-1-yuehaibing@huawei.com
State Accepted
Delegated to: David Miller
Headers show
Series [net-next] netdevsim: Make nsim_num_vf static | expand

Commit Message

Yue Haibing May 4, 2019, 8:12 a.m. UTC
Fix sparse warning:

drivers/net/netdevsim/bus.c:253:5: warning:
 symbol 'nsim_num_vf' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/net/netdevsim/bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski May 4, 2019, 11:07 a.m. UTC | #1
On Sat, 4 May 2019 16:12:07 +0800, YueHaibing wrote:
> Fix sparse warning:
> 
> drivers/net/netdevsim/bus.c:253:5: warning:
>  symbol 'nsim_num_vf' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>

Thanks!
David Miller May 5, 2019, 5:49 p.m. UTC | #2
From: YueHaibing <yuehaibing@huawei.com>
Date: Sat, 4 May 2019 16:12:07 +0800

> Fix sparse warning:
> 
> drivers/net/netdevsim/bus.c:253:5: warning:
>  symbol 'nsim_num_vf' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied.
diff mbox series

Patch

diff --git a/drivers/net/netdevsim/bus.c b/drivers/net/netdevsim/bus.c
index ae48234..868fb9a 100644
--- a/drivers/net/netdevsim/bus.c
+++ b/drivers/net/netdevsim/bus.c
@@ -250,7 +250,7 @@  static int nsim_bus_remove(struct device *dev)
 	return 0;
 }
 
-int nsim_num_vf(struct device *dev)
+static int nsim_num_vf(struct device *dev)
 {
 	struct nsim_bus_dev *nsim_bus_dev = to_nsim_bus_dev(dev);