From patchwork Sat May 4 04:05:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1095114 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44wwRg5Nkbz9s3l; Sat, 4 May 2019 14:06:37 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1hMlwW-00088P-Hn; Sat, 04 May 2019 04:06:32 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1hMlwV-00088G-0C for fwts-devel@lists.ubuntu.com; Sat, 04 May 2019 04:06:31 +0000 Received: from 1.general.alexhung.us.vpn ([10.172.65.254] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hMlvc-00054S-HD; Sat, 04 May 2019 04:05:36 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH] cpufreq: change from abort to skip when cpufreq cannot run Date: Fri, 3 May 2019 21:05:33 -0700 Message-Id: <20190504040533.29227-1-alex.hung@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" Starting from SandyBridge+, intel_pstate is used and cpufreq cannot be run by default kernel config. Therefore, changing warning messages to info and skip cpufreq test instead of abort. Signed-off-by: Alex Hung Acked-by: Colin Ian King Acked-by: Ivan Hu --- src/cpu/cpufreq/cpufreq.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cpu/cpufreq/cpufreq.c b/src/cpu/cpufreq/cpufreq.c index f43a5f60..60101f29 100644 --- a/src/cpu/cpufreq/cpufreq.c +++ b/src/cpu/cpufreq/cpufreq.c @@ -106,7 +106,7 @@ static int cpu_set_governor(fwts_framework *fw, struct cpu *cpu, out: if (rc != FWTS_OK) - fwts_warning(fw, "Cannot set CPU %d governor to %s.", + fwts_log_info(fw, "Cannot set CPU %d governor to %s.", cpu->idx, governor); return rc; } @@ -849,10 +849,10 @@ static int cpufreq_init(fwts_framework *fw) rc = cpu_set_governor(fw, &cpus[i], "userspace"); if (rc != FWTS_OK) { - fwts_log_warning(fw,"Failed to initialize cpufreq " + fwts_log_info(fw, "Cannot initialize cpufreq " "to set CPU speed for CPU %d", i); cpufreq_settable = false; - return FWTS_ERROR; + return FWTS_SKIP; } }