Patchwork [1/2] pseries: use macro for firmware filename

login
register
mail settings
Submitter David Gibson
Date Aug. 11, 2011, 2:36 a.m.
Message ID <1313030188-19347-2-git-send-email-david@gibson.dropbear.id.au>
Download mbox | patch
Permalink /patch/109486/
State New
Headers show

Comments

David Gibson - Aug. 11, 2011, 2:36 a.m.
From: Nishanth Aravamudan <nacc@us.ibm.com>

For some time we've had a nicely defined macro with the filename for our
firmware image.  However we didn't actually use it in the place we're
supposed to.  This patch fixes it.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/spapr.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Alexander Graf - Aug. 31, 2011, 9:18 a.m.
On 11.08.2011, at 04:36, David Gibson wrote:

> From: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> For some time we've had a nicely defined macro with the filename for our
> firmware image.  However we didn't actually use it in the place we're
> supposed to.  This patch fixes it.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>


Thanks, applied.


Alex

Patch

diff --git a/hw/spapr.c b/hw/spapr.c
index 7030c17..3f4433c 100644
--- a/hw/spapr.c
+++ b/hw/spapr.c
@@ -435,7 +435,7 @@  static void ppc_spapr_init(ram_addr_t ram_size,
                     "%ldM guest RAM\n", MIN_RAM_SLOF);
             exit(1);
         }
-        filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, "slof.bin");
+        filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, FW_FILE_NAME);
         fw_size = load_image_targphys(filename, 0, FW_MAX_SIZE);
         if (fw_size < 0) {
             hw_error("qemu: could not load LPAR rtas '%s'\n", filename);