Patchwork [13/16] usb-hid: add hid_has_events()

login
register
mail settings
Submitter Gerd Hoffmann
Date Aug. 10, 2011, 3:17 p.m.
Message ID <4E42A122.1020004@redhat.com>
Download mbox | patch
Permalink /patch/109384/
State New
Headers show

Comments

Gerd Hoffmann - Aug. 10, 2011, 3:17 p.m.
Hi,

>> -
>> -    /* Force poll routine to be run and grab input the first time.  */
>> -    us->changed = 1;
> USB tablet does not work on the winxp guest. I think this code can't be removed.
>

Attached patch should fix that.

cheers,
   Gerd
commit 21635e121ae0f0ab7874152a7c2f96e9d8cd642f
Author: Gerd Hoffmann <kraxel@redhat.com>
Date:   Tue Aug 9 12:35:57 2011 +0200

    usb/hid: add hid_pointer_activate, use it
    
    HID reorganziation broke the usb tablet in windows xp.  The reason is
    that xp activates idle before it starts polling, which creates a
    chicken-and-egg issue:  We don't call hid_pointer_poll because there are
    no pending events.  We don't get any events because the activation code
    in hid_pointer_poll is never executed and thus all pointer events are
    routed to the PS/2 mouse by qemu.
    
    Fix this by creating a hid_pointer_activate function and call it from
    usb-hid when the guest sets the idle state.
    
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
TeLeMan - Aug. 11, 2011, 5:45 a.m.
On Wed, Aug 10, 2011 at 23:17, Gerd Hoffmann <kraxel@redhat.com> wrote:
>  Hi,
>
>>> -
>>> -    /* Force poll routine to be run and grab input the first time.  */
>>> -    us->changed = 1;
>>
>> USB tablet does not work on the winxp guest. I think this code can't be
>> removed.
>>
>
> Attached patch should fix that.
Thanks, it works.

> cheers,
>  Gerd
>

Patch

diff --git a/hw/hid.c b/hw/hid.c
index 7b5ef5f..77339f7 100644
--- a/hw/hid.c
+++ b/hw/hid.c
@@ -218,16 +218,21 @@  static inline int int_clamp(int val, int vmin, int vmax)
     }
 }
 
+void hid_pointer_activate(HIDState *hs)
+{
+    if (!hs->ptr.mouse_grabbed) {
+        qemu_activate_mouse_event_handler(hs->ptr.eh_entry);
+        hs->ptr.mouse_grabbed = 1;
+    }
+}
+
 int hid_pointer_poll(HIDState *hs, uint8_t *buf, int len)
 {
     int dx, dy, dz, b, l;
     int index;
     HIDPointerEvent *e;
 
-    if (!hs->ptr.mouse_grabbed) {
-        qemu_activate_mouse_event_handler(hs->ptr.eh_entry);
-        hs->ptr.mouse_grabbed = 1;
-    }
+    hid_pointer_activate(hs);
 
     /* When the buffer is empty, return the last event.  Relative
        movements will all be zero.  */
diff --git a/hw/hid.h b/hw/hid.h
index 4a8fa5b..9ce03b1 100644
--- a/hw/hid.h
+++ b/hw/hid.h
@@ -51,6 +51,7 @@  void hid_free(HIDState *hs);
 
 bool hid_has_events(HIDState *hs);
 void hid_set_next_idle(HIDState *hs, int64_t curtime);
+void hid_pointer_activate(HIDState *hs);
 int hid_pointer_poll(HIDState *hs, uint8_t *buf, int len);
 int hid_keyboard_poll(HIDState *hs, uint8_t *buf, int len);
 int hid_keyboard_write(HIDState *hs, uint8_t *buf, int len);
diff --git a/hw/usb-hid.c b/hw/usb-hid.c
index e5d57de..6f12751 100644
--- a/hw/usb-hid.c
+++ b/hw/usb-hid.c
@@ -454,6 +454,9 @@  static int usb_hid_handle_control(USBDevice *dev, USBPacket *p,
     case SET_IDLE:
         hs->idle = (uint8_t) (value >> 8);
         hid_set_next_idle(hs, qemu_get_clock_ns(vm_clock));
+        if (hs->kind == HID_MOUSE || hs->kind == HID_TABLET) {
+            hid_pointer_activate(hs);
+        }
         ret = 0;
         break;
     default: