[-next] mlxsw: Remove obsolete dependency on THERMAL=m
diff mbox series

Message ID 20190430092832.7376-1-geert+renesas@glider.be
State Not Applicable
Delegated to: David Miller
Headers show
Series
  • [-next] mlxsw: Remove obsolete dependency on THERMAL=m
Related show

Commit Message

Geert Uytterhoeven April 30, 2019, 9:28 a.m. UTC
The THERMAL configuration option was changed from tristate to bool, but
a dependency on THERMAL=m was forgotten, leading to a warning when
running "make savedefconfig":

    boolean symbol THERMAL tested for 'm'? test forced to 'n'

Fixes: be33e4fbbea581ea ("thermal/drivers/core: Remove the module Kconfig's option")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Daniel Lezcano April 30, 2019, 9:38 a.m. UTC | #1
On 30/04/2019 11:28, Geert Uytterhoeven wrote:
> The THERMAL configuration option was changed from tristate to bool, but
> a dependency on THERMAL=m was forgotten, leading to a warning when
> running "make savedefconfig":
> 
>     boolean symbol THERMAL tested for 'm'? test forced to 'n'
> 
> Fixes: be33e4fbbea581ea ("thermal/drivers/core: Remove the module Kconfig's option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks!

Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>

> ---
>  drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
> index b6b3ff0fe17f5c4e..7ccb950aa7d4aa30 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
> +++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
> @@ -22,7 +22,6 @@ config MLXSW_CORE_HWMON
>  config MLXSW_CORE_THERMAL
>  	bool "Thermal zone support for Mellanox Technologies Switch ASICs"
>  	depends on MLXSW_CORE && THERMAL
> -	depends on !(MLXSW_CORE=y && THERMAL=m)
>  	default y
>  	---help---
>  	 Say Y here if you want to automatically control fans speed according
>
Ido Schimmel April 30, 2019, 10:16 a.m. UTC | #2
On Tue, Apr 30, 2019 at 11:28:32AM +0200, Geert Uytterhoeven wrote:
> The THERMAL configuration option was changed from tristate to bool, but
> a dependency on THERMAL=m was forgotten, leading to a warning when
> running "make savedefconfig":
> 
>     boolean symbol THERMAL tested for 'm'? test forced to 'n'
> 
> Fixes: be33e4fbbea581ea ("thermal/drivers/core: Remove the module Kconfig's option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Ido Schimmel <idosch@mellanox.com>

I assume this will be applied to the thermal tree?
Krzysztof Kozlowski May 3, 2019, 6:37 p.m. UTC | #3
On Tue, 30 Apr 2019 at 11:29, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> The THERMAL configuration option was changed from tristate to bool, but
> a dependency on THERMAL=m was forgotten, leading to a warning when
> running "make savedefconfig":
>
>     boolean symbol THERMAL tested for 'm'? test forced to 'n'
>
> Fixes: be33e4fbbea581ea ("thermal/drivers/core: Remove the module Kconfig's option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/net/ethernet/mellanox/mlxsw/Kconfig | 1 -
>  1 file changed, 1 deletion(-)

This also fixes olddefconfig, image_name and other targets:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Patch
diff mbox series

diff --git a/drivers/net/ethernet/mellanox/mlxsw/Kconfig b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
index b6b3ff0fe17f5c4e..7ccb950aa7d4aa30 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/Kconfig
+++ b/drivers/net/ethernet/mellanox/mlxsw/Kconfig
@@ -22,7 +22,6 @@  config MLXSW_CORE_HWMON
 config MLXSW_CORE_THERMAL
 	bool "Thermal zone support for Mellanox Technologies Switch ASICs"
 	depends on MLXSW_CORE && THERMAL
-	depends on !(MLXSW_CORE=y && THERMAL=m)
 	default y
 	---help---
 	 Say Y here if you want to automatically control fans speed according