Message ID | 20190430054937.29663-6-uboot@andestech.com |
---|---|
State | Superseded |
Delegated to: | Andes |
Headers | show |
Series | AE350 support SMP boot from flash | expand |
On Tue, Apr 30, 2019 at 1:55 PM Andes <uboot@andestech.com> wrote: > > From: Rick Chen <rick@andestech.com> > > When AE350 boots from flash, use CONFIG_OF_SEPARATE instead of > CONFIG_OF_BOARD. > > Also remove unused code about prior_stage_fdt_address. > And modify CONFIG_SYS_FDT_BASE as flash address. > > Signed-off-by: Rick Chen <rick@andestech.com> > Cc: Greentime Hu <greentime@andestech.com> > --- > board/AndesTech/ax25-ae350/ax25-ae350.c | 4 ---- > configs/ae350_rv32_xip_defconfig | 2 +- > configs/ae350_rv64_xip_defconfig | 2 +- > include/configs/ax25-ae350.h | 2 +- > 4 files changed, 3 insertions(+), 7 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Hi Rick, On Tue, 2019-04-30 at 13:49 +0800, Andes wrote: > From: Rick Chen <rick@andestech.com> > > When AE350 boots from flash, use CONFIG_OF_SEPARATE instead of > CONFIG_OF_BOARD. > > Also remove unused code about prior_stage_fdt_address. > And modify CONFIG_SYS_FDT_BASE as flash address. > > Signed-off-by: Rick Chen <rick@andestech.com> > Cc: Greentime Hu <greentime@andestech.com> > --- > board/AndesTech/ax25-ae350/ax25-ae350.c | 4 ---- > configs/ae350_rv32_xip_defconfig | 2 +- > configs/ae350_rv64_xip_defconfig | 2 +- > include/configs/ax25-ae350.h | 2 +- > 4 files changed, 3 insertions(+), 7 deletions(-) > > diff --git a/board/AndesTech/ax25-ae350/ax25-ae350.c b/board/AndesTech/ax25-ae350/ax25-ae350.c > index d343453..3d65ce7 100644 > --- a/board/AndesTech/ax25-ae350/ax25-ae350.c > +++ b/board/AndesTech/ax25-ae350/ax25-ae350.c > @@ -67,10 +67,6 @@ ulong board_flash_get_legacy(ulong base, int banknum, flash_info_t *info) > > void *board_fdt_blob_setup(void) > { > - void **ptr = (void *)&prior_stage_fdt_address; > - if (fdt_magic(*ptr) == FDT_MAGIC) > - return (void *)*ptr; > - > return (void *)CONFIG_SYS_FDT_BASE; > } > > diff --git a/configs/ae350_rv32_xip_defconfig b/configs/ae350_rv32_xip_defconfig > index 76534f2..07f1ecc 100644 > --- a/configs/ae350_rv32_xip_defconfig > +++ b/configs/ae350_rv32_xip_defconfig > @@ -15,7 +15,7 @@ CONFIG_CMD_SF_TEST=y > # CONFIG_CMD_SETEXPR is not set > CONFIG_BOOTP_PREFER_SERVERIP=y > CONFIG_CMD_CACHE=y > -CONFIG_OF_BOARD=y > +CONFIG_OF_SEPARATE=y > CONFIG_DEFAULT_DEVICE_TREE="ae350_32" > CONFIG_ENV_IS_IN_SPI_FLASH=y > CONFIG_NET_RANDOM_ETHADDR=y > diff --git a/configs/ae350_rv64_xip_defconfig b/configs/ae350_rv64_xip_defconfig > index f7f2925..28afd81 100644 > --- a/configs/ae350_rv64_xip_defconfig > +++ b/configs/ae350_rv64_xip_defconfig > @@ -16,7 +16,7 @@ CONFIG_CMD_SF_TEST=y > # CONFIG_CMD_SETEXPR is not set > CONFIG_BOOTP_PREFER_SERVERIP=y > CONFIG_CMD_CACHE=y > -CONFIG_OF_BOARD=y > +CONFIG_OF_SEPARATE=y > CONFIG_DEFAULT_DEVICE_TREE="ae350_64" > CONFIG_ENV_IS_IN_SPI_FLASH=y > CONFIG_NET_RANDOM_ETHADDR=y > diff --git a/include/configs/ax25-ae350.h b/include/configs/ax25-ae350.h > index 395f3a4..a4037f3 100644 > --- a/include/configs/ax25-ae350.h > +++ b/include/configs/ax25-ae350.h > @@ -40,7 +40,7 @@ > #define CONFIG_SYS_MALLOC_LEN (512 << 10) > > /* DT blob (fdt) address */ > -#define CONFIG_SYS_FDT_BASE 0x000f0000 > +#define CONFIG_SYS_FDT_BASE 0x800f0000 > > /* > * Physical Memory Map As a note, with CONFIG_OF_SEPARATE, the device tree will be automatically appended to the U-Boot binary. A fixed location for the device tree therefore does not have to be defined, meaning that you could remove the CONFIG_SYS_FDT_BASE define and the board_fdt_blob_setup() function. There are also reasons for using a fixed location for the device tree, so this is also fine. :) Reviewed-by: Lukas Auer <lukas.auer@aisec.fraunhofer.de> Thanks, Lukas
diff --git a/board/AndesTech/ax25-ae350/ax25-ae350.c b/board/AndesTech/ax25-ae350/ax25-ae350.c index d343453..3d65ce7 100644 --- a/board/AndesTech/ax25-ae350/ax25-ae350.c +++ b/board/AndesTech/ax25-ae350/ax25-ae350.c @@ -67,10 +67,6 @@ ulong board_flash_get_legacy(ulong base, int banknum, flash_info_t *info) void *board_fdt_blob_setup(void) { - void **ptr = (void *)&prior_stage_fdt_address; - if (fdt_magic(*ptr) == FDT_MAGIC) - return (void *)*ptr; - return (void *)CONFIG_SYS_FDT_BASE; } diff --git a/configs/ae350_rv32_xip_defconfig b/configs/ae350_rv32_xip_defconfig index 76534f2..07f1ecc 100644 --- a/configs/ae350_rv32_xip_defconfig +++ b/configs/ae350_rv32_xip_defconfig @@ -15,7 +15,7 @@ CONFIG_CMD_SF_TEST=y # CONFIG_CMD_SETEXPR is not set CONFIG_BOOTP_PREFER_SERVERIP=y CONFIG_CMD_CACHE=y -CONFIG_OF_BOARD=y +CONFIG_OF_SEPARATE=y CONFIG_DEFAULT_DEVICE_TREE="ae350_32" CONFIG_ENV_IS_IN_SPI_FLASH=y CONFIG_NET_RANDOM_ETHADDR=y diff --git a/configs/ae350_rv64_xip_defconfig b/configs/ae350_rv64_xip_defconfig index f7f2925..28afd81 100644 --- a/configs/ae350_rv64_xip_defconfig +++ b/configs/ae350_rv64_xip_defconfig @@ -16,7 +16,7 @@ CONFIG_CMD_SF_TEST=y # CONFIG_CMD_SETEXPR is not set CONFIG_BOOTP_PREFER_SERVERIP=y CONFIG_CMD_CACHE=y -CONFIG_OF_BOARD=y +CONFIG_OF_SEPARATE=y CONFIG_DEFAULT_DEVICE_TREE="ae350_64" CONFIG_ENV_IS_IN_SPI_FLASH=y CONFIG_NET_RANDOM_ETHADDR=y diff --git a/include/configs/ax25-ae350.h b/include/configs/ax25-ae350.h index 395f3a4..a4037f3 100644 --- a/include/configs/ax25-ae350.h +++ b/include/configs/ax25-ae350.h @@ -40,7 +40,7 @@ #define CONFIG_SYS_MALLOC_LEN (512 << 10) /* DT blob (fdt) address */ -#define CONFIG_SYS_FDT_BASE 0x000f0000 +#define CONFIG_SYS_FDT_BASE 0x800f0000 /* * Physical Memory Map