Patchwork logfs unmount bug

login
register
mail settings
Submitter Jörn Engel
Date Aug. 9, 2011, 2:58 p.m.
Message ID <20110809145812.GR26160@logfs.org>
Download mbox | patch
Permalink /patch/109239/
State New
Headers show

Comments

Jörn Engel - Aug. 9, 2011, 2:58 p.m.
On Mon, 8 August 2011 20:14:15 +0530, srimugunthan dhandapani wrote:
> 
> > Not good.  So far I managed to see a (the?) tiobench bug once, but
> > couldn't make it reproduceable.  Nor could I reproduce the bonnie bug.
> > Once the bugs are reproduceable, even my feeble eyes can usually spot
> > the cause sooner or later.  With a backtrace alone and no idea what
> > internal state it depends on, life is much harder.
> >
> 
> I am sorry , i dont know what i am missing. I tried it 5 times. 4/5
> trials, the bonnie test didnt complete. .Even when it completed once,
> the logs show kernel bug.

Ok, since I cannot reproduce this at all, can you try the patch below?
While it may already fix the problem, I am more interested in the
output.

>  do_invalidatepage+0x28/0x30
>  truncate_inode_page+0x92/0xb0
>  truncate_inode_pages_range+0x177/0x4f0
>  truncate_inode_pages+0x15/0x20
>  truncate_pagecache+0x4f/0x70
>  truncate_setsize+0x1f/0x30
>  vmtruncate+0x3e/0x60
>  logfs_truncate+0x263/0x2a0 [logfs]
>  logfs_evict_inode+0xdc/0x190 [logfs]
>  ? do_raw_spin_unlock+0x5e/0xb0
>  evict+0xa9/0x1a0
>  iput+0xfd/0x200

Jörn
srimugunthan dhandapani - Aug. 10, 2011, 11:06 a.m.
Hi,

>> I am sorry , i dont know what i am missing. I tried it 5 times. 4/5
>> trials, the bonnie test didnt complete. .Even when it completed once,
>> the logs show kernel bug.
>
> Ok, since I cannot reproduce this at all, can you try the patch below?

I was using a week-old kernel from git. That may be the problem,
Can you tell the kernel version that you are using, in which bonnie test passes.
I am right now trying on kernel 3.0 and i will test and let you know
the results.
thanks,
mugunthan

Patch

diff --git a/fs/logfs/file.c b/fs/logfs/file.c
index f2c08bc..7afd9a7 100644
--- a/fs/logfs/file.c
+++ b/fs/logfs/file.c
@@ -168,8 +168,14 @@  static void logfs_invalidatepage(struct page *page, unsigned long offset)
 		struct logfs_super *super = logfs_super(sb);
 
 		super->s_dirty_bytes -= block->reserved_bytes;
-		block->ops->free_block(sb, block);
-		BUG_ON(bitmap_weight(block->alias_map, LOGFS_BLOCK_FACTOR));
+		if (bitmap_weight(block->alias_map, LOGFS_BLOCK_FACTOR)) {
+			printk(KERN_DEBUG"logfs_invalidatepage(%lx, %x, %llx)\n",
+					page->mapping->host->i_ino,
+					page->mapping->host->i_nlink,
+					page->mapping->host->i_size);
+			move_page_to_btree(page);
+		} else
+			block->ops->free_block(sb, block);
 	} else
 		move_page_to_btree(page);
 	BUG_ON(PagePrivate(page) || page->private);