| Message ID | 20190426161406.5484-1-mmichels@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] OVN: Fix build when using a separate build directory. | expand |
On Fri, Apr 26, 2019, 9:55 PM Mark Michelson <mmichels@redhat.com> wrote: > The linker was searching for built libraries in the source directory > rather than in the build directory. This fixes the problem. > > Reported-by: Numan Siddique <numans@redhat.com> > Hi Mark Can you plz correct the email id - nusiddiq@redhat.com :) Thanks Numan Signed-off-by: Mark Michelson <mmichels@redhat.com> > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index e23df2647..0033d7fdc 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -77,8 +77,8 @@ AC_SUBST([LT_AGE]) > > AC_SUBST([ovs_srcdir], ['${top_srcdir}/ovs']) > AC_SUBST([ovs_builddir], ['${top_builddir}/ovs']) > -AC_SUBST([ovs_libdir], ['${top_srcdir}/ovs/lib']) > -AC_SUBST([ovsdb_libdir], ['${top_srcdir}/ovs/ovsdb']) > +AC_SUBST([ovs_libdir], ['${top_builddir}/ovs/lib']) > +AC_SUBST([ovsdb_libdir], ['${top_builddir}/ovs/ovsdb']) > AC_SUBST([ovs_mandir], ['${top_srcdir}/ovs/']) > > AC_SEARCH_LIBS([pow], [m]) > -- > 2.14.5 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev >
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (configure.ac). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 OVN: Fix build when using a separate build directory. The copy of the patch that failed is found in: /var/lib/jenkins/jobs/upstream_build_from_pw/workspace/.git/rebase-apply/patch When you have resolved this problem, run "git am --resolved". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email aconole@bytheb.org Thanks, 0-day Robot
On Fri, Apr 26, 2019 at 12:14:06PM -0400, Mark Michelson wrote: > The linker was searching for built libraries in the source directory > rather than in the build directory. This fixes the problem. > > Reported-by: Numan Siddique <numans@redhat.com> > Signed-off-by: Mark Michelson <mmichels@redhat.com> I did not test this but it looks perfectly reasonable. Acked-by: Ben Pfaff <blp@ovn.org>
On 4/26/19 2:14 PM, Ben Pfaff wrote: > On Fri, Apr 26, 2019 at 12:14:06PM -0400, Mark Michelson wrote: >> The linker was searching for built libraries in the source directory >> rather than in the build directory. This fixes the problem. >> >> Reported-by: Numan Siddique <numans@redhat.com> >> Signed-off-by: Mark Michelson <mmichels@redhat.com> > > I did not test this but it looks perfectly reasonable. > > Acked-by: Ben Pfaff <blp@ovn.org> > Thanks, I pushed this to master.
diff --git a/configure.ac b/configure.ac index e23df2647..0033d7fdc 100644 --- a/configure.ac +++ b/configure.ac @@ -77,8 +77,8 @@ AC_SUBST([LT_AGE]) AC_SUBST([ovs_srcdir], ['${top_srcdir}/ovs']) AC_SUBST([ovs_builddir], ['${top_builddir}/ovs']) -AC_SUBST([ovs_libdir], ['${top_srcdir}/ovs/lib']) -AC_SUBST([ovsdb_libdir], ['${top_srcdir}/ovs/ovsdb']) +AC_SUBST([ovs_libdir], ['${top_builddir}/ovs/lib']) +AC_SUBST([ovsdb_libdir], ['${top_builddir}/ovs/ovsdb']) AC_SUBST([ovs_mandir], ['${top_srcdir}/ovs/']) AC_SEARCH_LIBS([pow], [m])
The linker was searching for built libraries in the source directory rather than in the build directory. This fixes the problem. Reported-by: Numan Siddique <numans@redhat.com> Signed-off-by: Mark Michelson <mmichels@redhat.com> --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)