| Message ID | 1556119020-7609-4-git-send-email-eajames@linux.ibm.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Aspeed: Enable video engine | expand |
On Wed, 24 Apr 2019 10:16:59 -0500, Eddie James wrote: > Missed documenting this property in the initial commit. > > Signed-off-by: Eddie James <eajames@linux.ibm.com> > --- > Changes since v1: > - Add missing semi-colon > > Documentation/devicetree/bindings/media/aspeed-video.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
On 4/24/19 11:17 PM, Rob Herring wrote: > On Wed, 24 Apr 2019 10:16:59 -0500, Eddie James wrote: >> Missed documenting this property in the initial commit. >> >> Signed-off-by: Eddie James <eajames@linux.ibm.com> >> --- >> Changes since v1: >> - Add missing semi-colon >> >> Documentation/devicetree/bindings/media/aspeed-video.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. > I noticed the same when I was processing this patch. I've added back your 'Reviewed-by' tag. So there is no need to repost, Eddie. Just remember this for the next time :-) Regards, Hans
On 4/24/19 4:17 PM, Rob Herring wrote: > On Wed, 24 Apr 2019 10:16:59 -0500, Eddie James wrote: >> Missed documenting this property in the initial commit. >> >> Signed-off-by: Eddie James <eajames@linux.ibm.com> >> --- >> Changes since v1: >> - Add missing semi-colon >> >> Documentation/devicetree/bindings/media/aspeed-video.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. Yes, I left it off because I added a semi-colon (trivial, I know, but it did change). The change log is there below the commit message. Thanks, Eddie >
diff --git a/Documentation/devicetree/bindings/media/aspeed-video.txt b/Documentation/devicetree/bindings/media/aspeed-video.txt index 78b464a..ce28945 100644 --- a/Documentation/devicetree/bindings/media/aspeed-video.txt +++ b/Documentation/devicetree/bindings/media/aspeed-video.txt @@ -14,6 +14,11 @@ Required properties: the VE - interrupts: the interrupt associated with the VE on this platform +Optional properties: + - memory-region: + phandle to a memory region to allocate from, as defined in + Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt + Example: video-engine@1e700000 { @@ -23,4 +28,5 @@ video-engine@1e700000 { clock-names = "vclk", "eclk"; resets = <&syscon ASPEED_RESET_VIDEO>; interrupts = <7>; + memory-region = <&video_engine_memory>; };
Missed documenting this property in the initial commit. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- Changes since v1: - Add missing semi-colon Documentation/devicetree/bindings/media/aspeed-video.txt | 6 ++++++ 1 file changed, 6 insertions(+)