diff mbox series

[2/4] iprule: avoid trailing space in print_rule() after printing protocol

Message ID 20190423071615.19729-2-thaller@redhat.com
State Accepted
Delegated to: stephen hemminger
Headers show
Series [1/4] iprule: avoid printing extra space after gateway for nat action | expand

Commit Message

Thomas Haller April 23, 2019, 7:16 a.m. UTC 
It seems print_rule() tries to avoid a trailing space at the end
of the line. At least, when printing details about the actions,
they no longer append the space. Probably expecting to be the
last attribute that will be printed.

Don't let the protocol add the trailing space. The space at the end
of the line should be printed consistently (or not).

Signed-off-by: Thomas Haller <thaller@redhat.com>
---
 ip/iprule.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/ip/iprule.c b/ip/iprule.c
index 2479c3ab..ce6b7cd3 100644
--- a/ip/iprule.c
+++ b/ip/iprule.c
@@ -468,7 +468,7 @@  int print_rule(struct nlmsghdr *n, void *arg)
 		__u8 protocol = rta_getattr_u8(tb[FRA_PROTOCOL]);
 
 		if ((protocol && protocol != RTPROT_KERNEL) || show_details > 0) {
-			print_string(PRINT_ANY, "protocol", " proto %s ",
+			print_string(PRINT_ANY, "protocol", " proto %s",
 				     rtnl_rtprot_n2a(protocol, b1, sizeof(b1)));
 		}
 	}