diff mbox series

libext2fs: remove unused variable 'buff'

Message ID 20190422210843.185382-1-ebiggers@kernel.org
State Accepted, archived
Headers show
Series libext2fs: remove unused variable 'buff' | expand

Commit Message

Eric Biggers April 22, 2019, 9:08 p.m. UTC 
From: Eric Biggers <ebiggers@google.com>

In ext2fs_dirhash2(), the outer 'buff' variable is never used.

Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 lib/ext2fs/dirhash.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Gabriel Krisman Bertazi April 23, 2019, 4:06 a.m. UTC | #1 
Eric Biggers <ebiggers@kernel.org> writes:

> From: Eric Biggers <ebiggers@google.com>
>
> In ext2fs_dirhash2(), the outer 'buff' variable is never used.
>
> Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Theodore Ts'o April 29, 2019, 12:36 a.m. UTC | #2 
On Tue, Apr 23, 2019 at 12:06:35AM -0400, Gabriel Krisman Bertazi wrote:
> Eric Biggers <ebiggers@kernel.org> writes:
> 
> > From: Eric Biggers <ebiggers@google.com>
> >
> > In ext2fs_dirhash2(), the outer 'buff' variable is never used.
> >
> > Cc: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> 
> Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>

Thanks, applied.

					- Ted
diff mbox series

Patch

diff --git a/lib/ext2fs/dirhash.c b/lib/ext2fs/dirhash.c
index f1e7734d..97fd2431 100644
--- a/lib/ext2fs/dirhash.c
+++ b/lib/ext2fs/dirhash.c
@@ -279,7 +279,6 @@  errcode_t ext2fs_dirhash2(int version, const char *name, int len,
 {
 	errcode_t r;
 	int dlen;
-	unsigned char *buff;
 
 	if (len && charset) {
 		char buff[PATH_MAX];