| Message ID | 20190422101941.11335-1-wen.he_1@nxp.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v4] arm64: dts: ls1028a: Add properties for Mali DP500 node | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Mon, 22 Apr 2019 10:18:10 +0000, Wen He wrote: > The LS1028A has a LCD controller and Displayport interface that > connects to eDP and Displayport connectors on the LS1028A board. > > This patch enables the LCD controller driver on the LS1028A. > > Signed-off-by: Alison Wang <alison.wang@nxp.com> > Signed-off-by: Wen He <wen.he_1@nxp.com> > Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> > --- > change in v4: > - using 'malidp0:display' instead of the node name > 'display0:malidp'. > change in v3: > - using 'display0' instead of node name 'display-0' to > fixed syntax error. > > change in v2: > - renamed node name 'dp0' to be generic name 'display-0'. > - replace clk name 'xxclk' to 'clock-xx'. > - add newline between properties and child node. > > .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, Apr 22, 2019 at 10:18:10AM +0000, Wen He wrote: > The LS1028A has a LCD controller and Displayport interface that > connects to eDP and Displayport connectors on the LS1028A board. > > This patch enables the LCD controller driver on the LS1028A. > > Signed-off-by: Alison Wang <alison.wang@nxp.com> > Signed-off-by: Wen He <wen.he_1@nxp.com> > Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> Hi Wen, The base64 encoding of the message makes it very difficult to apply the patch. I managed to apply it manually this time, but please do not use base64 for future patch posting. Shawn
> -----Original Message----- > From: Shawn Guo [mailto:shawnguo@kernel.org] > Sent: 2019年5月10日 10:53 > To: Wen He <wen.he_1@nxp.com> > Cc: devicetree@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; > liviu.dudau@arm.com > Subject: [EXT] Re: [v4] arm64: dts: ls1028a: Add properties for Mali DP500 > node > > > On Mon, Apr 22, 2019 at 10:18:10AM +0000, Wen He wrote: > > The LS1028A has a LCD controller and Displayport interface that > > connects to eDP and Displayport connectors on the LS1028A board. > > > > This patch enables the LCD controller driver on the LS1028A. > > > > Signed-off-by: Alison Wang <alison.wang@nxp.com> > > Signed-off-by: Wen He <wen.he_1@nxp.com> > > Reviewed-by: Liviu Dudau <liviu.dudau@arm.com> > > Hi Wen, > > The base64 encoding of the message makes it very difficult to apply the patch. > I managed to apply it manually this time, but please do not use > base64 for future patch posting. > Hi Shawn, Thanks for your review. Thanks for you pointing out the issue. I will check the patch details for future posting as to avoid it. Best Regards, Wen > Shawn
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi index 8dd3501b1333..9b2b39eb37ef 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi @@ -70,6 +70,27 @@ clock-output-names = "sysclk"; }; + dpclk: clock-dp { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <27000000>; + clock-output-names= "dpclk"; + }; + + aclk: clock-axi { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <650000000>; + clock-output-names= "aclk"; + }; + + pclk: clock-apb { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <650000000>; + clock-output-names= "pclk"; + }; + reboot { compatible ="syscon-reboot"; regmap = <&dcfg>; @@ -433,4 +454,21 @@ }; }; }; + + malidp0: display@f080000 { + compatible = "arm,mali-dp500"; + reg = <0x0 0xf080000 0x0 0x10000>; + interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>, + <0 223 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "DE", "SE"; + clocks = <&dpclk>, <&aclk>, <&aclk>, <&pclk>; + clock-names = "pxlclk", "mclk", "aclk", "pclk"; + arm,malidp-output-port-lines = /bits/ 8 <8 8 8>; + + port { + dp0_out: endpoint { + + }; + }; + }; };