dt-bindings: add an explanation for internal phy-mode
diff mbox series

Message ID 1555784073-21679-1-git-send-email-clabbe@baylibre.com
State Not Applicable
Headers show
Series
  • dt-bindings: add an explanation for internal phy-mode
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Corentin Labbe April 20, 2019, 6:14 p.m. UTC
When working on the Allwinner internal PHY, the first work was to use
the "internal" mode, but some answer was made my mail on what are really
internal mean for PHY.

This patch write that in the doc.

Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
 Documentation/devicetree/bindings/net/ethernet.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Andrew Lunn April 21, 2019, 5:32 p.m. UTC | #1
On Sat, Apr 20, 2019 at 06:14:33PM +0000, Corentin Labbe wrote:
> When working on the Allwinner internal PHY, the first work was to use
> the "internal" mode, but some answer was made my mail on what are really
> internal mean for PHY.
> 
> This patch write that in the doc.
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
David Miller April 21, 2019, 6:24 p.m. UTC | #2
From: Corentin Labbe <clabbe@baylibre.com>
Date: Sat, 20 Apr 2019 18:14:33 +0000

> When working on the Allwinner internal PHY, the first work was to use
> the "internal" mode, but some answer was made my mail on what are really
> internal mean for PHY.
> 
> This patch write that in the doc.
> 
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>

Applied, thank you.

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/net/ethernet.txt b/Documentation/devicetree/bindings/net/ethernet.txt
index cfc376bc977a..78b098d2d4e9 100644
--- a/Documentation/devicetree/bindings/net/ethernet.txt
+++ b/Documentation/devicetree/bindings/net/ethernet.txt
@@ -18,7 +18,8 @@  Documentation/devicetree/bindings/phy/phy-bindings.txt.
   Specification).
 - phy-mode: string, operation mode of the PHY interface. This is now a de-facto
   standard property; supported values are:
-  * "internal"
+  * "internal" (Internal means there is not a standard bus between the MAC and
+     the PHY, something proprietary is being used to embed the PHY in the MAC.)
   * "mii"
   * "gmii"
   * "sgmii"