[OpenWrt-Devel] mvebu: add kmod-i2c-mux-pca954x for Turris Omnia
diff mbox series

Message ID 20190419230505.29593-1-josef.schlehofer@nic.cz
State Accepted
Delegated to: Petr Štetiar
Headers show
Series
  • [OpenWrt-Devel] mvebu: add kmod-i2c-mux-pca954x for Turris Omnia
Related show

Commit Message

Josef Schlehofer April 19, 2019, 11:05 p.m. UTC
The driver is for the I2C mux.
Schematic available at https://doc.turris.cz/doc/_media/rtrom01-schema.pdf

Signed-off-by: Josef Schlehofer <josef.schlehofer@nic.cz>
---
 target/linux/mvebu/image/cortex-a9.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rosen Penev April 24, 2019, 1:58 a.m. UTC | #1
On Fri, Apr 19, 2019 at 4:05 PM Josef Schlehofer
<josef.schlehofer@nic.cz> wrote:
>
> The driver is for the I2C mux.
> Schematic available at https://doc.turris.cz/doc/_media/rtrom01-schema.pdf
>
> Signed-off-by: Josef Schlehofer <josef.schlehofer@nic.cz>
Tested-by: Rosen Penev <rosenp@gmail.com>
> ---
>  target/linux/mvebu/image/cortex-a9.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/linux/mvebu/image/cortex-a9.mk b/target/linux/mvebu/image/cortex-a9.mk
> index 66cf54f9c5..f6d63fa786 100644
> --- a/target/linux/mvebu/image/cortex-a9.mk
> +++ b/target/linux/mvebu/image/cortex-a9.mk
> @@ -163,7 +163,7 @@ define Device/turris-omnia
>    DEVICE_PACKAGES :=  \
>      mkf2fs e2fsprogs kmod-fs-vfat kmod-nls-cp437 kmod-nls-iso8859-1 \
>      wpad-basic kmod-ath9k kmod-ath10k-ct ath10k-firmware-qca988x-ct \
> -    partx-utils
> +    partx-utils kmod-i2c-core kmod-i2c-mux kmod-i2c-mux-pca954x
>    IMAGES := $$(IMAGE_PREFIX)-sysupgrade.img.gz omnia-medkit-$$(IMAGE_PREFIX)-initramfs.tar.gz
>    IMAGE/$$(IMAGE_PREFIX)-sysupgrade.img.gz := boot-img | sdcard-img | gzip | append-metadata
>    IMAGE/omnia-medkit-$$(IMAGE_PREFIX)-initramfs.tar.gz := omnia-medkit-initramfs | gzip
> --
> 2.19.1
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Petr Štetiar May 3, 2019, 12:44 p.m. UTC | #2
Josef Schlehofer <josef.schlehofer@nic.cz> [2019-04-20 01:05:05]:

Hi,

> The driver is for the I2C mux.
> Schematic available at https://doc.turris.cz/doc/_media/rtrom01-schema.pdf
> 
> Signed-off-by: Josef Schlehofer <josef.schlehofer@nic.cz>
> ---
>  target/linux/mvebu/image/cortex-a9.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/linux/mvebu/image/cortex-a9.mk b/target/linux/mvebu/image/cortex-a9.mk
> index 66cf54f9c5..f6d63fa786 100644
> --- a/target/linux/mvebu/image/cortex-a9.mk
> +++ b/target/linux/mvebu/image/cortex-a9.mk
> @@ -163,7 +163,7 @@ define Device/turris-omnia
>    DEVICE_PACKAGES :=  \
>      mkf2fs e2fsprogs kmod-fs-vfat kmod-nls-cp437 kmod-nls-iso8859-1 \
>      wpad-basic kmod-ath9k kmod-ath10k-ct ath10k-firmware-qca988x-ct \
> -    partx-utils
> +    partx-utils kmod-i2c-core kmod-i2c-mux kmod-i2c-mux-pca954x

is there any reason for adding explicit kmod-i2c-core and kmod-i2c-mux
dependencies?

-- ynezz
Hauke Mehrtens May 3, 2019, 9:06 p.m. UTC | #3
On 5/3/19 2:44 PM, Petr Štetiar wrote:
> Josef Schlehofer <josef.schlehofer@nic.cz> [2019-04-20 01:05:05]:
> 
> Hi,
> 
>> The driver is for the I2C mux.
>> Schematic available at https://doc.turris.cz/doc/_media/rtrom01-schema.pdf
>>
>> Signed-off-by: Josef Schlehofer <josef.schlehofer@nic.cz>
>> ---
>>  target/linux/mvebu/image/cortex-a9.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/linux/mvebu/image/cortex-a9.mk b/target/linux/mvebu/image/cortex-a9.mk
>> index 66cf54f9c5..f6d63fa786 100644
>> --- a/target/linux/mvebu/image/cortex-a9.mk
>> +++ b/target/linux/mvebu/image/cortex-a9.mk
>> @@ -163,7 +163,7 @@ define Device/turris-omnia
>>    DEVICE_PACKAGES :=  \
>>      mkf2fs e2fsprogs kmod-fs-vfat kmod-nls-cp437 kmod-nls-iso8859-1 \
>>      wpad-basic kmod-ath9k kmod-ath10k-ct ath10k-firmware-qca988x-ct \
>> -    partx-utils
>> +    partx-utils kmod-i2c-core kmod-i2c-mux kmod-i2c-mux-pca954x
> 
> is there any reason for adding explicit kmod-i2c-core and kmod-i2c-mux
> dependencies?

Without giving all these options it is not possible to select
kmod-i2c-mux-pca954x.

kmod-i2c-mux is only shown in the menu if kmod-i2c-core is selected and
kmod-i2c-mux-pca954x is only shown if kmod-i2c-mux is selected, you have
to select all 3.

Hauke

Patch
diff mbox series

diff --git a/target/linux/mvebu/image/cortex-a9.mk b/target/linux/mvebu/image/cortex-a9.mk
index 66cf54f9c5..f6d63fa786 100644
--- a/target/linux/mvebu/image/cortex-a9.mk
+++ b/target/linux/mvebu/image/cortex-a9.mk
@@ -163,7 +163,7 @@  define Device/turris-omnia
   DEVICE_PACKAGES :=  \
     mkf2fs e2fsprogs kmod-fs-vfat kmod-nls-cp437 kmod-nls-iso8859-1 \
     wpad-basic kmod-ath9k kmod-ath10k-ct ath10k-firmware-qca988x-ct \
-    partx-utils
+    partx-utils kmod-i2c-core kmod-i2c-mux kmod-i2c-mux-pca954x
   IMAGES := $$(IMAGE_PREFIX)-sysupgrade.img.gz omnia-medkit-$$(IMAGE_PREFIX)-initramfs.tar.gz
   IMAGE/$$(IMAGE_PREFIX)-sysupgrade.img.gz := boot-img | sdcard-img | gzip | append-metadata
   IMAGE/omnia-medkit-$$(IMAGE_PREFIX)-initramfs.tar.gz := omnia-medkit-initramfs | gzip