From patchwork Thu Apr 18 17:38:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Brodkin X-Patchwork-Id: 1087754 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.133; helo=hemlock.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=synopsys.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=synopsys.com header.i=@synopsys.com header.b="gTn283Sv"; dkim-atps=neutral Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44lRDJ6wWhz9s4Y for ; Fri, 19 Apr 2019 03:38:56 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 3BDD186A45; Thu, 18 Apr 2019 17:38:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hBHv-s+00uyF; Thu, 18 Apr 2019 17:38:54 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 714BE86DAC; Thu, 18 Apr 2019 17:38:54 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id B45531BF28F for ; Thu, 18 Apr 2019 17:38:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id B0A6386F9E for ; Thu, 18 Apr 2019 17:38:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t8FUesw6LU7U for ; Thu, 18 Apr 2019 17:38:51 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from smtprelay-out1.synopsys.com (dc8-smtprelay2.synopsys.com [198.182.47.102]) by whitealder.osuosl.org (Postfix) with ESMTPS id B4F58870D5 for ; Thu, 18 Apr 2019 17:38:51 +0000 (UTC) Received: from mailhost.synopsys.com (dc8-mailhost2.synopsys.com [10.13.135.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id DCEE1C0B01; Thu, 18 Apr 2019 17:38:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1555609131; bh=4i51KxIbGDlhqICdOqoxNwkglQUJuAQujX4ETzIz/ZM=; h=From:To:Cc:Subject:Date:From; b=gTn283Sv8+CkhJq9pJHydko+pcskvAVD+Bhh1QaMEzBDXw0EnWVx1FiryG3xdFJnV S9k0bhiGMDuL02hMac8dOZjblqgim9YXCG/E5ylE45KaXuajCZwJp94PNyxs6R7I44 nnCX4CFJRpxInlKqhg6Q0+vAO3B9e9DU2dTPaw5maFBmZ9j6T3F7MS2/VQVZvU6VHm Q9xapD+WrWfhbVDVErRwcX1UHp017sBUNTQFFaVAKbmH0lqA8U/6NNd2LqXLfwCDv3 ocWrkysWYLxYZ4u1YX1dGnsqzNeFbe2R329kaXtLviHRznGzAUwwsA2d8Ne/y/mbOg OdOzVchaaY9xw== Received: from ru20arcgnu1.internal.synopsys.com (ru20arcgnu1.internal.synopsys.com [10.121.9.48]) by mailhost.synopsys.com (Postfix) with ESMTP id 1A87FA0065; Thu, 18 Apr 2019 17:38:49 +0000 (UTC) From: Alexey Brodkin To: buildroot@busybox.net Date: Thu, 18 Apr 2019 20:38:45 +0300 Message-Id: <20190418173845.14495-1-abrodkin@synopsys.com> X-Mailer: git-send-email 2.16.2 Subject: [Buildroot] [PATCH v2] linux-tools/perf: Add dependency on 32-bit atomics X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Brodkin , ARC Buildroot mailing list , Thomas Petazzoni MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Atomic ops are strictly required by perf utility as it uses atomic_xxx() functions. Otherwise building fails like that: |.../output/host/opt/ext-toolchain/bin/../lib/gcc/arc-snps-linux-uclibc/8.2.1/../../../../arc-snps-linux-uclibc/bin/ld: |.../output/build/linux-5.0.7/tools/perf/libperf.a(libperf-in.o): in function `atomic_cmpxchg': |.../output/build/linux-5.0.7/tools/include/asm-generic/atomic-gcc.h:69: undefined reference to `__sync_val_compare_and_swap_4' Signed-off-by: Alexey Brodkin Cc: Thomas Petazzoni --- Changes v1 -> v2: * Depend on generic BR2_TOOLCHAIN_HAS_SYNC_4 package/linux-tools/Config.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/linux-tools/Config.in b/package/linux-tools/Config.in index 4916faa349..104065b22d 100644 --- a/package/linux-tools/Config.in +++ b/package/linux-tools/Config.in @@ -46,6 +46,7 @@ config BR2_PACKAGE_LINUX_TOOLS_PCI config BR2_PACKAGE_LINUX_TOOLS_PERF bool "perf" select BR2_PACKAGE_LINUX_TOOLS + depends on BR2_TOOLCHAIN_HAS_SYNC_4 help perf (sometimes "Perf Events" or perf tools, originally "Performance Counters for Linux") - is a performance @@ -64,6 +65,9 @@ config BR2_PACKAGE_LINUX_TOOLS_PERF https://perf.wiki.kernel.org/ +comment "perf needs 32-bit atomic ops" + depends on !BR2_TOOLCHAIN_HAS_SYNC_4 + if BR2_PACKAGE_LINUX_TOOLS_PERF config BR2_PACKAGE_LINUX_TOOLS_PERF_TUI