From patchwork Fri Aug 5 18:42:47 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dirk Behme X-Patchwork-Id: 108711 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3D211B6F76 for ; Sat, 6 Aug 2011 04:43:34 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 53E58280AD; Fri, 5 Aug 2011 20:43:32 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bxl9jLhe58gT; Fri, 5 Aug 2011 20:43:32 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1AE93280AF; Fri, 5 Aug 2011 20:43:30 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9637C280AF for ; Fri, 5 Aug 2011 20:43:28 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8RRj2hUiGZle for ; Fri, 5 Aug 2011 20:43:27 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-ew0-f44.google.com (mail-ew0-f44.google.com [209.85.215.44]) by theia.denx.de (Postfix) with ESMTPS id 12ECE280AD for ; Fri, 5 Aug 2011 20:43:25 +0200 (CEST) Received: by ewy19 with SMTP id 19so311877ewy.3 for ; Fri, 05 Aug 2011 11:43:25 -0700 (PDT) Received: by 10.213.29.210 with SMTP id r18mr269025ebc.35.1312569804930; Fri, 05 Aug 2011 11:43:24 -0700 (PDT) Received: from linux.local ([46.115.9.124]) by mx.google.com with ESMTPS id c50sm610725eeb.0.2011.08.05.11.43.21 (version=SSLv3 cipher=OTHER); Fri, 05 Aug 2011 11:43:24 -0700 (PDT) From: Dirk Behme To: u-boot@lists.denx.de Date: Fri, 5 Aug 2011 20:42:47 +0200 Message-Id: <1312569767-4395-1-git-send-email-dirk.behme@gmail.com> X-Mailer: git-send-email 1.7.3.2 Subject: [U-Boot] [PATCH] mkimage: Fix 'Unknown OMAP image type - 5' X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de From: Dirk Behme Using mkimage with e.g. tools/mkimage -A arm -T firmware -O u-boot -d u-boot.bin foo.img gives a warning "Unknown OMAP image type - 5" while it seems that the image itself is created successfully. This does come from the patch "mkimage: Add OMAP boot image support". Reordering the init_xx_image_type() sequence does make this message go away. Signed-off-by: Dirk Behme CC: John Rigby CC: Aneesh V CC: Sandeep Paulraj Tested-by: Aneesh V --- This is reproducable with the recent mainline mkimage where the patch "mkimage: Add OMAP boot image support" is applied: http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=commit;h=3decb14abe76d244ba98fd158ef95f89e7e37d70 tools/mkimage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: u-boot.git/tools/mkimage.c =================================================================== --- u-boot.git.orig/tools/mkimage.c +++ u-boot.git/tools/mkimage.c @@ -156,12 +156,12 @@ main (int argc, char **argv) init_imx_image_type (); /* Init FIT image generation/list support */ init_fit_image_type (); - /* Init TI OMAP Boot image generation/list support */ - init_omap_image_type(); /* Init Default image generation/list support */ init_default_image_type (); /* Init Davinci UBL support */ init_ubl_image_type(); + /* Init TI OMAP Boot image generation/list support */ + init_omap_image_type(); params.cmdname = *argv; params.addr = params.ep = 0;