diff mbox

[U-Boot,v2] MAKEALL ARM: Use boards.cfg

Message ID 1312568442-6043-1-git-send-email-dirk.behme@gmail.com
State Superseded
Headers show

Commit Message

Dirk Behme Aug. 5, 2011, 6:20 p.m. UTC 
From: Dirk Behme <dirk.behme@googlemail.com>

Use the boards from boards.cfg for building ./MAKEALL ARMx.

Note: ARM10 systems don't seem to exist any more.

Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>

---
Changes in v2: Instead of dublicating the missing boards from
boards.cfg to MAKEALL, use the boards defined in boards.cfg
directly.

 MAKEALL |  134 ++++------------------------------------------------------------
 1 file changed, 9 insertions(+), 125 deletions(-)

Comments

Reinhard Meyer Aug. 5, 2011, 8:40 p.m. UTC | #1 
Dear Dirk Behme,

> From: Dirk Behme <dirk.behme@googlemail.com>
> 
> Use the boards from boards.cfg for building ./MAKEALL ARMx.
> 
> Note: ARM10 systems don't seem to exist any more.

Wrong: a simple grep shows that those are still in Makefile.

> 
> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
> 
> ---
> Changes in v2: Instead of dublicating the missing boards from
> boards.cfg to MAKEALL, use the boards defined in boards.cfg
> directly.

This sentence does not make sense to me...
How can something that is missing be duplicated?
I think you were wanting to say: "remove all boards that are in
boards.cfg from MAKEALL"

> 
>  MAKEALL |  134 ++++------------------------------------------------------------
>  1 file changed, 9 insertions(+), 125 deletions(-)

Are all those boards removed here in boards.cfg?
Answer: NO
Are none of them still in Makefile?
Answer: NO

Remember:
1. boards must either be in Makefile OR boards.cfg
2. boards that are still in Makefile MUST BE in MAKEALL
3. boards that are in boards.cfg SHOULD NOT be in MAKEALL

Of the boards removed from MAKEALL by your patch, I found several in
Makefile but not in boards.cfg.

By removing them from MAKEALL they will not be built any more in MAKEALL
runs and this would hide their possible brokenness!

Best Regards,
Reinhard
diff mbox

Patch

Index: u-boot.git/MAKEALL
===================================================================
--- u-boot.git.orig/MAKEALL
+++ u-boot.git/MAKEALL
@@ -300,144 +300,28 @@  LIST_SA="$(boards_by_cpu sa1100)"
 ## ARM7 Systems
 #########################################################################
 
-LIST_ARM7="		\
-	ap7		\
-	ap720t		\
-	armadillo	\
-	B2		\
-	ep7312		\
-	evb4510		\
-	impa7		\
-	integratorap	\
-	lpc2292sodimm	\
-	modnet50	\
-	SMN42		\
-"
+LIST_ARM7="$(boards_by_cpu arm720t)"
 
 #########################################################################
 ## ARM9 Systems
 #########################################################################
 
-LIST_ARM9="			\
-	a320evb			\
-	ap920t			\
-	ap922_XA10		\
-	ap926ejs		\
-	ap946es			\
-	ap966			\
-	aspenite		\
-	cp920t			\
-	cp922_XA10		\
-	cp926ejs		\
-	cp946es			\
-	cp966			\
-	da830evm		\
-	da850evm		\
-	edb9301			\
-	edb9302			\
-	edb9302a		\
-	edb9307			\
-	edb9307a		\
-	edb9312			\
-	edb9315			\
-	edb9315a		\
-	edminiv2		\
-	guruplug		\
-	imx27lite		\
-	jadecpu			\
-	km_kirkwood		\
-	lpd7a400		\
-	magnesium		\
-	mv88f6281gtw_ge		\
-	mx1ads			\
-	mx1fs2			\
-	netstar			\
-	nhk8815			\
-	nhk8815_onenand		\
-	omap1510inn		\
-	omap1610h2		\
-	omap1610inn		\
-	omap5912osk		\
-	omap730p2		\
-	openrd_base		\
-	openrd_client		\
-	openrd_ultimate		\
-	portl2			\
-	rd6281a			\
-	sbc2410x		\
-	scb9328			\
-	sheevaplug		\
-	smdk2400		\
-	smdk2410		\
-	spear300		\
-	spear310		\
-	spear320		\
-	spear600		\
-	VCMA9			\
-	versatile		\
-	versatileab		\
-	versatilepb		\
-	voiceblue		\
-	davinci_dvevm		\
-	davinci_schmoogie	\
-	davinci_sffsdr		\
-	davinci_sonata		\
-	davinci_dm355evm	\
-	davinci_dm355leopard	\
-	davinci_dm365evm	\
-	davinci_dm6467evm	\
-"
-
-#########################################################################
-## ARM10 Systems
-#########################################################################
-LIST_ARM10="		\
-	integratorcp	\
-	cp1026		\
-"
+LIST_ARM9="$(boards_by_cpu arm920t)
+	$(boards_by_cpu arm925t)
+	$(boards_by_cpu arm926ejs)"
 
 #########################################################################
 ## ARM11 Systems
 #########################################################################
-LIST_ARM11="			\
-	cp1136			\
-	omap2420h4		\
-	apollon			\
-	imx31_litekit		\
-	imx31_phycore		\
-	imx31_phycore_eet	\
-	mx31ads			\
-	mx31pdk			\
-	mx31pdk_nand		\
-	qong			\
-	smdk6400		\
-	tnetv107x_evm		\
-"
+
+LIST_ARM11="$(boards_by_cpu arm1136)
+	$(boards_by_cpu arm1176)"
 
 #########################################################################
 ## ARMV7 Systems
 #########################################################################
-LIST_ARMV7="		\
-	am3517_crane		\
-	am3517_evm		\
-	ca9x4_ct_vxp		\
-	devkit8000		\
-	dig297			\
-	igep0020		\
-	igep0030		\
-	mx51evk			\
-	omap3_beagle		\
-	omap3_overo		\
-	omap3_evm		\
-	omap3_pandora		\
-	omap3_sdp3430		\
-	omap3_zoom1		\
-	omap3_zoom2		\
-	omap4_panda		\
-	omap4_sdp4430		\
-	s5p_goni		\
-	smdkc100		\
-"
+
+LIST_ARMV7="$(boards_by_cpu armv7)"
 
 #########################################################################
 ## AT91 Systems