diff mbox series

[U-Boot,v2,1/2] ARM: dts: Freescale: Add ecc addr for sata node

Message ID 20190417074842.42916-1-peng.ma@nxp.com
State Superseded
Delegated to: Prabhakar Kushwaha
Headers show
Series [U-Boot,v2,1/2] ARM: dts: Freescale: Add ecc addr for sata node | expand

Commit Message

Peng Ma April 17, 2019, 7:48 a.m. UTC
Move the ecc addr from driver to dts.

Signed-off-by: Peng Ma <peng.ma@nxp.com>
---
changed for v2:
	- Add reg-names to improve driver code.

 arch/arm/dts/fsl-ls1012a.dtsi |    4 +++-
 arch/arm/dts/fsl-ls1043a.dtsi |    4 +++-
 arch/arm/dts/fsl-ls1046a.dtsi |    4 +++-
 arch/arm/dts/fsl-ls1088a.dtsi |    3 +++
 arch/arm/dts/ls1021a.dtsi     |    4 +++-
 5 files changed, 15 insertions(+), 4 deletions(-)

Comments

Prabhakar Kushwaha May 22, 2019, 12:32 p.m. UTC | #1
> -----Original Message-----
> From: Peng Ma <peng.ma@nxp.com>
> Sent: Wednesday, April 17, 2019 1:19 PM
> To: albert.u.boot@aribaud.net; sjg@chromium.org; Fabio Estevam
> <fabio.estevam@nxp.com>; York Sun <york.sun@nxp.com>; Prabhakar
> Kushwaha <prabhakar.kushwaha@nxp.com>
> Cc: Andy Tang <andy.tang@nxp.com>; Yinbo Zhu <yinbo.zhu@nxp.com>;
> michal.simek@xilinx.com; u-boot@lists.denx.de; Peng Ma
> <peng.ma@nxp.com>
> Subject: [v2 1/2] ARM: dts: Freescale: Add ecc addr for sata node
> 
> Move the ecc addr from driver to dts.
> 
> Signed-off-by: Peng Ma <peng.ma@nxp.com>
> ---
> changed for v2:
> 	- Add reg-names to improve driver code.
> 

fix chechpatch warning i.e. updated subject and applied to fsl-qoriq master, awaiting upstream

Can you send patches for ls2088a and ls1028a also

--pk
Peng Ma May 23, 2019, 4:10 a.m. UTC | #2
Hi prabhakar,

>-----Original Message-----
>From: Prabhakar Kushwaha
>Sent: 2019年5月22日 20:33
>To: Peng Ma <peng.ma@nxp.com>; albert.u.boot@aribaud.net;
>sjg@chromium.org; Fabio Estevam <fabio.estevam@nxp.com>; York Sun
><york.sun@nxp.com>
>Cc: Andy Tang <andy.tang@nxp.com>; Yinbo Zhu <yinbo.zhu@nxp.com>;
>michal.simek@xilinx.com; u-boot@lists.denx.de; Peng Ma
><peng.ma@nxp.com>
>Subject: RE: [v2 1/2] ARM: dts: Freescale: Add ecc addr for sata node
>
>
>> -----Original Message-----
>> From: Peng Ma <peng.ma@nxp.com>
>> Sent: Wednesday, April 17, 2019 1:19 PM
>> To: albert.u.boot@aribaud.net; sjg@chromium.org; Fabio Estevam
>> <fabio.estevam@nxp.com>; York Sun <york.sun@nxp.com>; Prabhakar
>> Kushwaha <prabhakar.kushwaha@nxp.com>
>> Cc: Andy Tang <andy.tang@nxp.com>; Yinbo Zhu <yinbo.zhu@nxp.com>;
>> michal.simek@xilinx.com; u-boot@lists.denx.de; Peng Ma
>> <peng.ma@nxp.com>
>> Subject: [v2 1/2] ARM: dts: Freescale: Add ecc addr for sata node
>>
>> Move the ecc addr from driver to dts.
>>
>> Signed-off-by: Peng Ma <peng.ma@nxp.com>
>> ---
>> changed for v2:
>> 	- Add reg-names to improve driver code.
>>
>
>fix chechpatch warning i.e. updated subject and applied to fsl-qoriq master,
>awaiting upstream
>
>Can you send patches for ls2088a and ls1028a also
[Peng Ma] ls2088a is not need to ecc address, I will
add ls1028 patch to upstream.

Best Regards,
Peng
>
>--pk
diff mbox series

Patch

diff --git a/arch/arm/dts/fsl-ls1012a.dtsi b/arch/arm/dts/fsl-ls1012a.dtsi
index f22cbf4..30af2e1 100644
--- a/arch/arm/dts/fsl-ls1012a.dtsi
+++ b/arch/arm/dts/fsl-ls1012a.dtsi
@@ -136,7 +136,9 @@ 
 
 		sata: sata@3200000 {
 			compatible = "fsl,ls1012a-ahci";
-			reg = <0x0 0x3200000 0x0 0x10000>;
+			reg = <0x0 0x3200000 0x0 0x10000	/* ccsr sata base */
+			       0x0 0x20140520 0x0 0x4>;		/* ecc sata addr*/
+			reg-names = "sata-base", "ecc-addr";
 			interrupts = <0 69 4>;
 			clocks = <&clockgen 4 0>;
 			status = "disabled";
diff --git a/arch/arm/dts/fsl-ls1043a.dtsi b/arch/arm/dts/fsl-ls1043a.dtsi
index bb70992..c7fa9e2 100644
--- a/arch/arm/dts/fsl-ls1043a.dtsi
+++ b/arch/arm/dts/fsl-ls1043a.dtsi
@@ -290,7 +290,9 @@ 
 
 		sata: sata@3200000 {
 			compatible = "fsl,ls1043a-ahci";
-			reg = <0x0 0x3200000 0x0 0x10000>;
+			reg = <0x0 0x3200000 0x0 0x10000	/* ccsr sata base */
+			       0x0 0x20140520 0x0 0x4>;		/* ecc sata addr*/
+			reg-names = "sata-base", "ecc-addr";
 			interrupts = <0 69 4>;
 			clocks = <&clockgen 4 0>;
 			status = "disabled";
diff --git a/arch/arm/dts/fsl-ls1046a.dtsi b/arch/arm/dts/fsl-ls1046a.dtsi
index 5ac10e0..d56ecd6 100644
--- a/arch/arm/dts/fsl-ls1046a.dtsi
+++ b/arch/arm/dts/fsl-ls1046a.dtsi
@@ -294,7 +294,9 @@ 
 
 		sata: sata@3200000 {
 			compatible = "fsl,ls1046a-ahci";
-			reg = <0x0 0x3200000 0x0 0x10000>;
+			reg = <0x0 0x3200000 0x0 0x10000	/* ccsr sata base */
+			       0x0 0x20140520 0x0 0x4>;		/* ecc sata addr*/
+			reg-names = "sata-base", "ecc-addr";
 			interrupts = <0 69 4>;
 			clocks = <&clockgen 4 1>;
 			status = "disabled";
diff --git a/arch/arm/dts/fsl-ls1088a.dtsi b/arch/arm/dts/fsl-ls1088a.dtsi
index 9455e03..7ba0683 100644
--- a/arch/arm/dts/fsl-ls1088a.dtsi
+++ b/arch/arm/dts/fsl-ls1088a.dtsi
@@ -154,6 +154,9 @@ 
 	sata: sata@3200000 {
 		compatible = "fsl,ls1088a-ahci";
 		reg = <0x0 0x3200000 0x0 0x10000>;
+		reg = <0x0 0x3200000 0x0 0x10000	/* ccsr sata base */
+		       0x7 0x100520  0x0 0x4>;		/* ecc sata addr*/
+		reg-names = "sata-base", "ecc-addr";
 		interrupts = <0 133 4>;
 		status = "disabled";
 	};
diff --git a/arch/arm/dts/ls1021a.dtsi b/arch/arm/dts/ls1021a.dtsi
index 7670a39..cc5d56c 100644
--- a/arch/arm/dts/ls1021a.dtsi
+++ b/arch/arm/dts/ls1021a.dtsi
@@ -406,7 +406,9 @@ 
 
 		sata: sata@3200000 {
 			compatible = "fsl,ls1021a-ahci";
-			reg = <0x3200000 0x10000>;
+			reg = <0x0 0x3200000 0x0 0x10000	/* ccsr sata base */
+			       0x0 0x20220520 0x0 0x4>;		/* ecc sata addr*/
+			reg-names = "sata-base", "ecc-addr";
 			interrupts = <0 101 4>;
 			status = "disabled";
 		};