From patchwork Tue Apr 16 01:57:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver O'Halloran X-Patchwork-Id: 1086040 X-Patchwork-Delegate: hegdevasant@linux.vnet.ibm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44js3P0L1Kz9s3q for ; Tue, 16 Apr 2019 13:55:45 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Beb0A162"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44js3N3pZWzDq9y for ; Tue, 16 Apr 2019 13:55:44 +1000 (AEST) X-Original-To: skiboot-stable@lists.ozlabs.org Delivered-To: skiboot-stable@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::441; helo=mail-pf1-x441.google.com; envelope-from=oohall@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Beb0A162"; dkim-atps=neutral Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44jpQr0v3NzDqGJ; Tue, 16 Apr 2019 11:57:22 +1000 (AEST) Received: by mail-pf1-x441.google.com with SMTP id w25so9537665pfi.9; Mon, 15 Apr 2019 18:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tDGizAlE/RN7fh6k1l0RO0e/MnxkvmISWymsTDBImN4=; b=Beb0A162peXF0/YCG+vhDXh8Lfj5l5p7pktISr/uITGKF881YLhhI/3XunodrUyo2m GjSPMMg5mQdy04VdNHjfNWf04NyiBDCaYL2Yal35d1YCIKCzA5oxM13yPEjCi5apBMar G0DCUoi2UhtC3+NoI1fjWUzMlcaRZEJOxHWIF6mzRKwBLNjy/K0zvKHUYoIqgU+tXzqW JbtOGgBbomEYZNHPRKkltrgiEPw0Bg6hUZI39FKk276QtaEna7/fr3lrI5NvWw6Mw4FC zifgiGVxl5PvPt4YQsDX99XvJO3H4x5EsCmBo0U7zt28LDcj6/J9at+st+2l/e87GoUK D/fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tDGizAlE/RN7fh6k1l0RO0e/MnxkvmISWymsTDBImN4=; b=q7mx+1jAut25pyQu6eakCHNiLvqHJwVWwPobEJoLWxTjaef3YR3UZ66NW2S2UPYt+L ycAKYz5/sLugntD1CkvDxkxZUJcwB4K+VksX2T4YWzst70FG6FzZtluIi0ePWvchatPC xKbsqaBGfTaNUAXDFHHhOPTk3bWwwNm50n+WJf6//FoMLYQoIC6I9MnJs2klG/Fr/bRt L1CwEH8yoL/S0ekBj+eWjVBDBjLeeOi1W+7uTXpPhRrkRTK7KZHsqvaK1HE7gQ/sRtRg GvaT9ZgSBPnuJDN3SAbYfraOSDcUbtSLGatfWzwGK8D82ffLG+6Q8UN3RDDoftt7n33E Lm9w== X-Gm-Message-State: APjAAAUYE19XPMUVTq8rdBHFyWti45W4zRx/pP1yb/unJCs3bU35rx8o d1Aft2ZPdqn1+JUCP44IVEXfaJ2I X-Google-Smtp-Source: APXvYqxlCfODnX9R+GoCd/VzEgXpTE4fFqlAv/eA8Re8tg2muPVeXo2vVVYqAUZYleaey+McU8MIgg== X-Received: by 2002:a63:6a42:: with SMTP id f63mr72448475pgc.207.1555379837557; Mon, 15 Apr 2019 18:57:17 -0700 (PDT) Received: from wafer.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id x24sm68419842pfn.128.2019.04.15.18.57.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 15 Apr 2019 18:57:16 -0700 (PDT) From: Oliver O'Halloran To: skiboot@lists.ozlabs.org Date: Tue, 16 Apr 2019 11:57:01 +1000 Message-Id: <20190416015701.24170-1-oohall@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 16 Apr 2019 13:55:40 +1000 Subject: [Skiboot-stable] [PATCH] hw/xscom: Enable sw xstop by default on p9 X-BeenThere: skiboot-stable@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Patches, review, and discussion for stable releases of skiboot" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: skiboot-stable@lists.ozlabs.org, Oliver O'Halloran Errors-To: skiboot-stable-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot-stable" This was disabled at some point during bringup to make life easier for the lab folks trying to debug NVLink issues. This hack really should have never made it out into the wild though, so we now have the following situation occuring in the field: 1) A bad happens 2) The host kernel recieves an unrecoverable HMI and calls into OPAL to request a platform reboot. 3) OPAL rejects the reboot attempt and returns to the kernel with OPAL_PARAMETER. 4) Kernel panics and attempts to kexec into a kdump kernel. A side effect of the HMI seems to be CPUs becoming stuck which results in the initialisation of the kdump kernel taking a extremely long time (6+ hours). It's also been observed that after performing a dump the kdump kernel then crashes itself because OPAL has ended up in a bad state as a side effect of the HMI. All up, it's not very good so re-enable the software checkstop by default. If people still want to turn it off they can using the nvram override. Cc: skiboot-stable@lists.ozlabs.org Cc: Mahesh Salgaonkar Signed-off-by: Oliver O'Halloran Acked-by: Mahesh Salgaonkar --- hw/xscom.c | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/hw/xscom.c b/hw/xscom.c index 37f0705d1c2a..bf634d91a960 100644 --- a/hw/xscom.c +++ b/hw/xscom.c @@ -833,30 +833,8 @@ int64_t xscom_trigger_xstop(void) int rc = OPAL_UNSUPPORTED; bool xstop_disabled = false; - /* - * Workaround until we iron out all checkstop issues at present. - * - * For p9: - * By default do not trigger sw checkstop unless explicitly enabled - * through nvram option 'opal-sw-xstop=enable'. - * - * For p8: - * Keep it enabled by default unless explicitly disabled. - * - * NOTE: Once all checkstop issues are resolved/stabilized reverse - * the logic to enable sw checkstop by default on p9. - */ - switch (proc_gen) { - case proc_gen_p8: - if (nvram_query_eq("opal-sw-xstop", "disable")) - xstop_disabled = true; - break; - case proc_gen_p9: - default: - if (!nvram_query_eq("opal-sw-xstop", "enable")) - xstop_disabled = true; - break; - } + if (nvram_query_eq("opal-sw-xstop", "disable")) + xstop_disabled = true; if (xstop_disabled) { prlog(PR_NOTICE, "Software initiated checkstop disabled.\n");