Patchwork mtd/physmap: Fix set_vpp signature in physmap_configure

login
register
mail settings
Submitter Grant Likely
Date Aug. 4, 2011, 10:53 p.m.
Message ID <1312498433-17950-1-git-send-email-grant.likely@secretlab.ca>
Download mbox | patch
Permalink /patch/108583/
State New
Headers show

Comments

Grant Likely - Aug. 4, 2011, 10:53 p.m.
physmap_configure() has the wrong signature for the set_vpp callback.
struct physmap_flash_data expects it to accpet a platform_device
pointer.

However, I can't find any users of physmap_configure(), so maybe the
hook should simply be removed.

Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
 drivers/mtd/maps/physmap.c  |    2 +-
 include/linux/mtd/physmap.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Patch

diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
index f64cee4..f2b9f5e 100644
--- a/drivers/mtd/maps/physmap.c
+++ b/drivers/mtd/maps/physmap.c
@@ -247,7 +247,7 @@  static struct platform_device physmap_flash = {
 };
 
 void physmap_configure(unsigned long addr, unsigned long size,
-		int bankwidth, void (*set_vpp)(struct map_info *, int))
+		int bankwidth, void (*set_vpp)(struct platform_device *, int))
 {
 	physmap_flash_resource.start = addr;
 	physmap_flash_resource.end = addr + size - 1;
diff --git a/include/linux/mtd/physmap.h b/include/linux/mtd/physmap.h
index e5f21d2..25ef3ed 100644
--- a/include/linux/mtd/physmap.h
+++ b/include/linux/mtd/physmap.h
@@ -36,7 +36,7 @@  struct physmap_flash_data {
  * Board needs to specify the exact mapping during their setup time.
  */
 void physmap_configure(unsigned long addr, unsigned long size,
-		int bankwidth, void (*set_vpp)(struct map_info *, int) );
+		int bankwidth, void (*set_vpp)(struct platform_device *, int) );
 
 /*
  * Machines that wish to do flash partition may want to call this function in