Patchwork [Fortran,testsuite,committed] Add/fix dg-final cleanup-module

login
register
mail settings
Submitter Steve Kargl
Date Aug. 4, 2011, 9:46 p.m.
Message ID <20110804214608.GA17556@troutmask.apl.washington.edu>
Download mbox | patch
Permalink /patch/108574/
State New
Headers show

Comments

Steve Kargl - Aug. 4, 2011, 9:46 p.m.
On Thu, Aug 04, 2011 at 11:36:11PM +0200, Mikael Morin wrote:
> On Thursday 04 August 2011 22:45:34 Steve Kargl wrote:
> > On Tue, Aug 02, 2011 at 05:34:46PM +0200, Tobias Burnus wrote:
> > > There might be still some missing or wrong cleanups, but most remaining
> > > .mod files are from gfortran.fortran-torture.
> > 
> > Yes, you missed a few.
> 
> And you missed my two patches from yesterday. ;-)
> 
> http://gcc.gnu.org/ml/fortran/2011-08/msg00015.html
> http://gcc.gnu.org/ml/fortran/2011-08/msg00017.html

I saw your emails.  I did not read your patches.
My statement above is correct.  Tobias missed a
few. :-)  I had a testsuite cleanup patch sitting
in my tree for several weeks/months; never got 
around to committing it.

ps: bessel_6.f90 is broken, but it won't show up
until glibc finally fixes its libm.
Mikael Morin - Aug. 5, 2011, 9:48 a.m.
On Thursday 04 August 2011 23:46:08 Steve Kargl wrote:
> On Thu, Aug 04, 2011 at 11:36:11PM +0200, Mikael Morin wrote:
> > On Thursday 04 August 2011 22:45:34 Steve Kargl wrote:
> > > On Tue, Aug 02, 2011 at 05:34:46PM +0200, Tobias Burnus wrote:
> > > > There might be still some missing or wrong cleanups, but most
> > > > remaining .mod files are from gfortran.fortran-torture.
> > > 
> > > Yes, you missed a few.
> > 
> > And you missed my two patches from yesterday. ;-)
> > 
> > http://gcc.gnu.org/ml/fortran/2011-08/msg00015.html
> > http://gcc.gnu.org/ml/fortran/2011-08/msg00017.html
> 
> I saw your emails.
Note that I didn't say you missed them. :-)

> I did not read your patches.
> My statement above is correct.  Tobias missed a
> few. :-)  I had a testsuite cleanup patch sitting
> in my tree for several weeks/months; never got
> around to committing it.
> 
> ps: bessel_6.f90 is broken, but it won't show up
> until glibc finally fixes its libm.
> 
> 
> Index: gcc/testsuite/gfortran.dg/bessel_6.f90
> ===================================================================
> --- gcc/testsuite/gfortran.dg/bessel_6.f90	(revision 177414)
> +++ gcc/testsuite/gfortran.dg/bessel_6.f90	(working copy)
> @@ -12,7 +12,7 @@
>  implicit none
>  real,parameter :: values(*) = [0.0, 0.5, 1.0, 0.9,
> 1.8,2.0,3.0,4.0,4.25,8.0,34.53, 475.78] real,parameter ::
> myeps(size(values)) = epsilon(0.0) &
> -                  * [2, 7, 5, 6, 9, 12, 12, 7, 7, 8, 75, 15 ]
> +                  * [2, 7, 5, 6, 9, 12, 12, 7, 7, 8, 92, 15 ]
>  ! The following is sufficient for me - the values above are a bit
>  ! more tolerant
>  !                  * [0, 5, 3, 4, 6, 7, 7, 5, 5, 6, 66, 4 ]

If you are seeking approval for this, it is OK.

Mikael

Patch

Index: gcc/testsuite/gfortran.dg/bessel_6.f90
===================================================================
--- gcc/testsuite/gfortran.dg/bessel_6.f90	(revision 177414)
+++ gcc/testsuite/gfortran.dg/bessel_6.f90	(working copy)
@@ -12,7 +12,7 @@ 
 implicit none
 real,parameter :: values(*) = [0.0, 0.5, 1.0, 0.9, 1.8,2.0,3.0,4.0,4.25,8.0,34.53, 475.78] 
 real,parameter :: myeps(size(values)) = epsilon(0.0) &
-                  * [2, 7, 5, 6, 9, 12, 12, 7, 7, 8, 75, 15 ]
+                  * [2, 7, 5, 6, 9, 12, 12, 7, 7, 8, 92, 15 ]
 ! The following is sufficient for me - the values above are a bit
 ! more tolerant
 !                  * [0, 5, 3, 4, 6, 7, 7, 5, 5, 6, 66, 4 ]