Patchwork [01/10] dma-helpers: allow including from target-independent code

login
register
mail settings
Submitter Paolo Bonzini
Date Aug. 4, 2011, 5:14 p.m.
Message ID <1312478089-806-2-git-send-email-pbonzini@redhat.com>
Download mbox | patch
Permalink /patch/108544/
State New
Headers show

Comments

Paolo Bonzini - Aug. 4, 2011, 5:14 p.m.
Target-independent code cannot construct sglists, but it can take
them from the outside as a black box.  Allow this.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 dma.h         |   12 ++++++++----
 qemu-common.h |    1 +
 2 files changed, 9 insertions(+), 4 deletions(-)

Patch

diff --git a/dma.h b/dma.h
index 3d8324b..f7e0142 100644
--- a/dma.h
+++ b/dma.h
@@ -15,22 +15,26 @@ 
 #include "hw/hw.h"
 #include "block.h"
 
-typedef struct {
+typedef struct ScatterGatherEntry ScatterGatherEntry;
+
+#if defined(TARGET_PHYS_ADDR_BITS)
+struct ScatterGatherEntry {
     target_phys_addr_t base;
     target_phys_addr_t len;
-} ScatterGatherEntry;
+};
 
-typedef struct {
+struct QEMUSGList {
     ScatterGatherEntry *sg;
     int nsg;
     int nalloc;
     target_phys_addr_t size;
-} QEMUSGList;
+};
 
 void qemu_sglist_init(QEMUSGList *qsg, int alloc_hint);
 void qemu_sglist_add(QEMUSGList *qsg, target_phys_addr_t base,
                      target_phys_addr_t len);
 void qemu_sglist_destroy(QEMUSGList *qsg);
+#endif
 
 typedef BlockDriverAIOCB *DMAIOFunc(BlockDriverState *bs, int64_t sector_num,
                                  QEMUIOVector *iov, int nb_sectors,
diff --git a/qemu-common.h b/qemu-common.h
index 1e3c665..69c6595 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -18,6 +18,7 @@  typedef struct DeviceState DeviceState;
 
 struct Monitor;
 typedef struct Monitor Monitor;
+typedef struct QEMUSGList QEMUSGList;
 
 /* we put basic includes here to avoid repeating them in device drivers */
 #include <stdlib.h>