From patchwork Thu Aug 4 16:24:59 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 108537 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 1F464B6F62 for ; Fri, 5 Aug 2011 02:22:15 +1000 (EST) Received: from localhost ([::1]:56601 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qp0gW-0003ER-Do for incoming@patchwork.ozlabs.org; Thu, 04 Aug 2011 12:22:12 -0400 Received: from eggs.gnu.org ([140.186.70.92]:33125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qp0gQ-0003Dt-Pd for qemu-devel@nongnu.org; Thu, 04 Aug 2011 12:22:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qp0gP-0007gp-OM for qemu-devel@nongnu.org; Thu, 04 Aug 2011 12:22:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21046) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qp0gP-0007gf-FG for qemu-devel@nongnu.org; Thu, 04 Aug 2011 12:22:05 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p74GM3E2001837 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 4 Aug 2011 12:22:03 -0400 Received: from dhcp-5-188.str.redhat.com (vpn1-7-174.ams2.redhat.com [10.36.7.174]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p74GM10n003032; Thu, 4 Aug 2011 12:22:02 -0400 From: Kevin Wolf To: anthony@codemonkey.ws Date: Thu, 4 Aug 2011 18:24:59 +0200 Message-Id: <1312475099-3323-1-git-send-email-kwolf@redhat.com> In-Reply-To: References: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, hahn@univention.de Subject: [Qemu-devel] [PATCH v2 0.15.0] qcow2: Fix L1 table size after bdrv_snapshot_goto X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org When loading an internal snapshot whose L1 table is smaller than the current L1 table, the size of the current L1 would be shrunk to the snapshot's L1 size in memory, but not on disk. This lead to incorrect refcount updates and eventuelly to image corruption. Instead of writing the new L1 size to disk, this simply retains the bigger L1 size that is currently in use and makes sure that the unused part is zeroed. Signed-off-by: Kevin Wolf Tested-by: Philipp Hahn --- And the moment you send it out, you notice that it's wrong... *sigh* v2: - Check for s->l1_size > sn->l1_size in order to avoid disasters... Philipp, I think this should fix your corruption. Please give it a try. Anthony, this must go into 0.15. Given the short time until -rc2, do you prefer to pick it up directly or should I send a pull request tomorrow? The patch looks obvious, is tested with the given testcase and survives a basic qemu-iotests run (though qemu-iotests doesn't exercise snapshots a lot) Stefan, please review :-) block/qcow2-snapshot.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index 74823a5..6972e66 100644 --- a/block/qcow2-snapshot.c +++ b/block/qcow2-snapshot.c @@ -330,8 +330,11 @@ int qcow2_snapshot_goto(BlockDriverState *bs, const char *snapshot_id) if (qcow2_grow_l1_table(bs, sn->l1_size, true) < 0) goto fail; - s->l1_size = sn->l1_size; + if (s->l1_size > sn->l1_size) { + memset(s->l1_table + sn->l1_size, 0, s->l1_size - sn->l1_size); + } l1_size2 = s->l1_size * sizeof(uint64_t); + /* copy the snapshot l1 table to the current l1 table */ if (bdrv_pread(bs->file, sn->l1_table_offset, s->l1_table, l1_size2) != l1_size2)