diff mbox series

[U-Boot] drivers/usb/host/Kconfig: Drop CONFIG_ prefix from select

Message ID alpine.LFD.2.21.1904140604220.5466@localhost.localdomain
State Superseded
Delegated to: Tom Rini
Headers show
Series [U-Boot] drivers/usb/host/Kconfig: Drop CONFIG_ prefix from select | expand

Commit Message

Robert P. J. Day April 14, 2019, 10:06 a.m. UTC 
Kbuild "select" directives should not include "CONFIG_" prefix.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

Comments

Marek Vasut April 14, 2019, 10:15 a.m. UTC | #1 
On 4/14/19 12:06 PM, Robert P. J. Day wrote:
> 
> Kbuild "select" directives should not include "CONFIG_" prefix.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

The patch is correct, but does it have any side-effects ?

> ---
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index ba1e6bfa43..96474f4e3b 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -204,7 +204,7 @@ config USB_EHCI_GENERIC
>  config USB_EHCI_FSL
>  	bool  "Support for FSL on-chip EHCI USB controller"
>  	default n
> -	select  CONFIG_EHCI_HCD_INIT_AFTER_RESET
> +	select EHCI_HCD_INIT_AFTER_RESET
>  	---help---
>  	  Enables support for the on-chip EHCI controller on FSL chips.
>  endif # USB_EHCI_HCD
>
Robert P. J. Day April 14, 2019, 10:51 a.m. UTC | #2 
On Sun, 14 Apr 2019, Marek Vasut wrote:

> On 4/14/19 12:06 PM, Robert P. J. Day wrote:
> >
> > Kbuild "select" directives should not include "CONFIG_" prefix.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> The patch is correct, but does it have any side-effects ?
>
> > ---
> >
> > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> > index ba1e6bfa43..96474f4e3b 100644
> > --- a/drivers/usb/host/Kconfig
> > +++ b/drivers/usb/host/Kconfig
> > @@ -204,7 +204,7 @@ config USB_EHCI_GENERIC
> >  config USB_EHCI_FSL
> >  	bool  "Support for FSL on-chip EHCI USB controller"
> >  	default n
> > -	select  CONFIG_EHCI_HCD_INIT_AFTER_RESET
> > +	select EHCI_HCD_INIT_AFTER_RESET
> >  	---help---
> >  	  Enables support for the on-chip EHCI controller on FSL chips.
> >  endif # USB_EHCI_HCD
> >

  there are a *ton* of include/configs/ header files that
already contain:

  #define CONFIG_EHCI_HCD_INIT_AFTER_RESET

and the only test i can see for it is in drivers/usb/host/ehci-hcd.c:

  #if defined(CONFIG_EHCI_HCD_INIT_AFTER_RESET)
        rc = ehci_hcd_init(index, init, &ctrl->hccr, &ctrl->hcor);
        if (rc)
                return rc;
  #endif

so i would *think* that, given the number of boards that already
explicitly include that feature, it's unlikely that fixing that
Kconfig file would suddenly reveal an issue that was hidden until now.
but that's just a guess.

rday
Marek Vasut April 14, 2019, 11:32 a.m. UTC | #3 
On 4/14/19 12:51 PM, Robert P. J. Day wrote:
> On Sun, 14 Apr 2019, Marek Vasut wrote:
> 
>> On 4/14/19 12:06 PM, Robert P. J. Day wrote:
>>>
>>> Kbuild "select" directives should not include "CONFIG_" prefix.
>>>
>>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>>
>> The patch is correct, but does it have any side-effects ?
>>
>>> ---
>>>
>>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>>> index ba1e6bfa43..96474f4e3b 100644
>>> --- a/drivers/usb/host/Kconfig
>>> +++ b/drivers/usb/host/Kconfig
>>> @@ -204,7 +204,7 @@ config USB_EHCI_GENERIC
>>>  config USB_EHCI_FSL
>>>  	bool  "Support for FSL on-chip EHCI USB controller"
>>>  	default n
>>> -	select  CONFIG_EHCI_HCD_INIT_AFTER_RESET
>>> +	select EHCI_HCD_INIT_AFTER_RESET
>>>  	---help---
>>>  	  Enables support for the on-chip EHCI controller on FSL chips.
>>>  endif # USB_EHCI_HCD
>>>
> 
>   there are a *ton* of include/configs/ header files that
> already contain:
> 
>   #define CONFIG_EHCI_HCD_INIT_AFTER_RESET

And those boards also enable USB_EHCI_FSL ? If so, then it might also
make sense to remove these #define CONFIG_EHCI_HCD_INIT_AFTER_RESET from
the header files.

I think ./tools/moveconfig.py could help you with that cleanup .

> and the only test i can see for it is in drivers/usb/host/ehci-hcd.c:
> 
>   #if defined(CONFIG_EHCI_HCD_INIT_AFTER_RESET)
>         rc = ehci_hcd_init(index, init, &ctrl->hccr, &ctrl->hcor);
>         if (rc)
>                 return rc;
>   #endif
> 
> so i would *think* that, given the number of boards that already
> explicitly include that feature, it's unlikely that fixing that
> Kconfig file would suddenly reveal an issue that was hidden until now.
> but that's just a guess.
> 
> rday
>
Robert P. J. Day April 14, 2019, 11:40 a.m. UTC | #4 
On Sun, 14 Apr 2019, Marek Vasut wrote:

> On 4/14/19 12:51 PM, Robert P. J. Day wrote:
> > On Sun, 14 Apr 2019, Marek Vasut wrote:
> >
> >> On 4/14/19 12:06 PM, Robert P. J. Day wrote:
> >>>
> >>> Kbuild "select" directives should not include "CONFIG_" prefix.
> >>>
> >>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >>
> >> The patch is correct, but does it have any side-effects ?
> >>
> >>> ---
> >>>
> >>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> >>> index ba1e6bfa43..96474f4e3b 100644
> >>> --- a/drivers/usb/host/Kconfig
> >>> +++ b/drivers/usb/host/Kconfig
> >>> @@ -204,7 +204,7 @@ config USB_EHCI_GENERIC
> >>>  config USB_EHCI_FSL
> >>>  	bool  "Support for FSL on-chip EHCI USB controller"
> >>>  	default n
> >>> -	select  CONFIG_EHCI_HCD_INIT_AFTER_RESET
> >>> +	select EHCI_HCD_INIT_AFTER_RESET
> >>>  	---help---
> >>>  	  Enables support for the on-chip EHCI controller on FSL chips.
> >>>  endif # USB_EHCI_HCD
> >>>
> >
> >   there are a *ton* of include/configs/ header files that
> > already contain:
> >
> >   #define CONFIG_EHCI_HCD_INIT_AFTER_RESET
>
> And those boards also enable USB_EHCI_FSL ? If so, then it might
> also make sense to remove these #define
> CONFIG_EHCI_HCD_INIT_AFTER_RESET from the header files.
>
> I think ./tools/moveconfig.py could help you with that cleanup .

  ok, i'll take a closer look first chance i get. clearly, there's
potentially more cleanup here than just fixing a typo.

rday
Marek Vasut April 14, 2019, 11:43 a.m. UTC | #5 
On 4/14/19 1:40 PM, Robert P. J. Day wrote:
> On Sun, 14 Apr 2019, Marek Vasut wrote:
> 
>> On 4/14/19 12:51 PM, Robert P. J. Day wrote:
>>> On Sun, 14 Apr 2019, Marek Vasut wrote:
>>>
>>>> On 4/14/19 12:06 PM, Robert P. J. Day wrote:
>>>>>
>>>>> Kbuild "select" directives should not include "CONFIG_" prefix.
>>>>>
>>>>> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>>>>
>>>> The patch is correct, but does it have any side-effects ?
>>>>
>>>>> ---
>>>>>
>>>>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>>>>> index ba1e6bfa43..96474f4e3b 100644
>>>>> --- a/drivers/usb/host/Kconfig
>>>>> +++ b/drivers/usb/host/Kconfig
>>>>> @@ -204,7 +204,7 @@ config USB_EHCI_GENERIC
>>>>>  config USB_EHCI_FSL
>>>>>  	bool  "Support for FSL on-chip EHCI USB controller"
>>>>>  	default n
>>>>> -	select  CONFIG_EHCI_HCD_INIT_AFTER_RESET
>>>>> +	select EHCI_HCD_INIT_AFTER_RESET
>>>>>  	---help---
>>>>>  	  Enables support for the on-chip EHCI controller on FSL chips.
>>>>>  endif # USB_EHCI_HCD
>>>>>
>>>
>>>   there are a *ton* of include/configs/ header files that
>>> already contain:
>>>
>>>   #define CONFIG_EHCI_HCD_INIT_AFTER_RESET
>>
>> And those boards also enable USB_EHCI_FSL ? If so, then it might
>> also make sense to remove these #define
>> CONFIG_EHCI_HCD_INIT_AFTER_RESET from the header files.
>>
>> I think ./tools/moveconfig.py could help you with that cleanup .
> 
>   ok, i'll take a closer look first chance i get. clearly, there's
> potentially more cleanup here than just fixing a typo.

Thanks!
diff mbox series

Patch

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index ba1e6bfa43..96474f4e3b 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -204,7 +204,7 @@  config USB_EHCI_GENERIC
 config USB_EHCI_FSL
 	bool  "Support for FSL on-chip EHCI USB controller"
 	default n
-	select  CONFIG_EHCI_HCD_INIT_AFTER_RESET
+	select EHCI_HCD_INIT_AFTER_RESET
 	---help---
 	  Enables support for the on-chip EHCI controller on FSL chips.
 endif # USB_EHCI_HCD