diff mbox series

[e2fsprogs,05/10] ext2fs: nls: Merge sparse fixes from the kernel version

Message ID 20190413054317.7388-6-krisman@collabora.com
State Accepted, archived
Headers show
Series case-insensitive feature updates | expand

Commit Message

Gabriel Krisman Bertazi April 13, 2019, 5:43 a.m. UTC 
The sparse script complained about the following issues in the kernel
version of this script.  This patch port the fixes to the userspace
version.

sparse warnings: (new ones prefixed by >>)

>> fs/unicode/utf8-norm.c:41:24: sparse: non-ANSI function declaration
   of function 'utf8version_latest'

vim +/utf8version_latest +41 fs/unicode/utf8-norm.c

  40
> 41	int utf8version_latest()
  42	{
  43		return utf8vers;
  44		}
  45	EXPORT_SYMBOL(utf8version_latest);
  46

Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
---
 lib/ext2fs/nls_utf8-norm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Theodore Ts'o April 28, 2019, 7:12 p.m. UTC | #1 
On Sat, Apr 13, 2019 at 01:43:12AM -0400, Gabriel Krisman Bertazi wrote:
> The sparse script complained about the following issues in the kernel
> version of this script.  This patch port the fixes to the userspace
> version.
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> fs/unicode/utf8-norm.c:41:24: sparse: non-ANSI function declaration
>    of function 'utf8version_latest'
> 
> vim +/utf8version_latest +41 fs/unicode/utf8-norm.c
> 
>   40
> > 41	int utf8version_latest()
>   42	{
>   43		return utf8vers;
>   44		}
>   45	EXPORT_SYMBOL(utf8version_latest);
>   46
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>

Thanks, applied.

						- Ted
diff mbox series

Patch

diff --git a/lib/ext2fs/nls_utf8-norm.c b/lib/ext2fs/nls_utf8-norm.c
index 4230b64bc586..27e530c14e4f 100644
--- a/lib/ext2fs/nls_utf8-norm.c
+++ b/lib/ext2fs/nls_utf8-norm.c
@@ -46,7 +46,7 @@  int utf8version_is_supported(uint8_t maj, uint8_t min, uint8_t rev)
 	return 0;
 }
 
-int utf8version_latest()
+int utf8version_latest(void)
 {
 	return utf8vers;
 }