From patchwork Thu Aug 4 13:15:51 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaud Charlet X-Patchwork-Id: 108451 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 47498B6F68 for ; Thu, 4 Aug 2011 23:16:08 +1000 (EST) Received: (qmail 31774 invoked by alias); 4 Aug 2011 13:16:06 -0000 Received: (qmail 31765 invoked by uid 22791); 4 Aug 2011 13:16:06 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,TW_PR X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Aug 2011 13:15:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F42102BB3AA; Thu, 4 Aug 2011 09:15:51 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id zHgnLhNAQDM3; Thu, 4 Aug 2011 09:15:51 -0400 (EDT) Received: from kwai.gnat.com (kwai.gnat.com [205.232.38.4]) by rock.gnat.com (Postfix) with ESMTP id E19E42BB3A9; Thu, 4 Aug 2011 09:15:51 -0400 (EDT) Received: by kwai.gnat.com (Postfix, from userid 4192) id E108B3FEE8; Thu, 4 Aug 2011 09:15:51 -0400 (EDT) Date: Thu, 4 Aug 2011 09:15:51 -0400 From: Arnaud Charlet To: gcc-patches@gcc.gnu.org Cc: Vincent Celier Subject: [Ada] Extending library projects with no sources does not build Message-ID: <20110804131551.GA28691@adacore.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org If a library project extending another one has no sources of its own, and there is an exception name with capital letters in the project being extended, then on platform with case-insensitive file names (such a Windows, Darwin or VMS), the invocation of gnatmake to build the library will fail. Tested on x86_64-pc-linux-gnu, committed on trunk 2011-08-04 Vincent Celier * prj-env.adb (For_All_Source_Dirs.For_Project): Check if project Prj has Ada sources, not project Project, because if the root project Project has no sources of its own, all projects will be deemed without sources. Index: prj-env.adb =================================================================== --- prj-env.adb (revision 177367) +++ prj-env.adb (working copy) @@ -1281,7 +1281,7 @@ -- If there are Ada sources, call action with the name of every -- source directory. - if Has_Ada_Sources (Project) then + if Has_Ada_Sources (Prj) then while Current /= Nil_String loop The_String := In_Tree.Shared.String_Elements.Table (Current); Action (Get_Name_String (The_String.Display_Value));