| Message ID | 20190411170355.6882-31-mmaddireddy@nvidia.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Enable Tegra PCIe root port features | expand |
On Thu, Apr 11, 2019 at 10:33:55PM +0530, Manikanta Maddireddy wrote: > Link retry log is info log not error, so change it to INFO log level. The wording here is confusing. The log is clearly error level right now. Perhaps you meant to say something like this: Letting users know that a link is down and in the process of being brought up again is informational, not an error condition. Thierry > > Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> > --- > drivers/pci/controller/pci-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c > index 75873e6627f9..55f8ff4f3e07 100644 > --- a/drivers/pci/controller/pci-tegra.c > +++ b/drivers/pci/controller/pci-tegra.c > @@ -2461,7 +2461,7 @@ static bool tegra_pcie_port_check_link(struct tegra_pcie_port *port) > } while (--timeout); > > if (!timeout) { > - dev_err(dev, "link %u down, retrying\n", port->index); > + dev_info(dev, "link %u down, retrying\n", port->index); > goto retry; > } > > -- > 2.17.1 >
On 15-Apr-19 7:53 PM, Thierry Reding wrote: > On Thu, Apr 11, 2019 at 10:33:55PM +0530, Manikanta Maddireddy wrote: >> Link retry log is info log not error, so change it to INFO log level. > The wording here is confusing. The log is clearly error level right now. > Perhaps you meant to say something like this: > > Letting users know that a link is down and in the process of being > brought up again is informational, not an error condition. > > Thierry I will update in V2. Manikanta > >> Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> >> --- >> drivers/pci/controller/pci-tegra.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c >> index 75873e6627f9..55f8ff4f3e07 100644 >> --- a/drivers/pci/controller/pci-tegra.c >> +++ b/drivers/pci/controller/pci-tegra.c >> @@ -2461,7 +2461,7 @@ static bool tegra_pcie_port_check_link(struct tegra_pcie_port *port) >> } while (--timeout); >> >> if (!timeout) { >> - dev_err(dev, "link %u down, retrying\n", port->index); >> + dev_info(dev, "link %u down, retrying\n", port->index); >> goto retry; >> } >> >> -- >> 2.17.1 >>
diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c index 75873e6627f9..55f8ff4f3e07 100644 --- a/drivers/pci/controller/pci-tegra.c +++ b/drivers/pci/controller/pci-tegra.c @@ -2461,7 +2461,7 @@ static bool tegra_pcie_port_check_link(struct tegra_pcie_port *port) } while (--timeout); if (!timeout) { - dev_err(dev, "link %u down, retrying\n", port->index); + dev_info(dev, "link %u down, retrying\n", port->index); goto retry; }
Link retry log is info log not error, so change it to INFO log level. Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> --- drivers/pci/controller/pci-tegra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)