| Message ID | 4E3A7CE8.4080407@mellanox.co.il |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
> For older FW versions, when a Mac address removed from Mac table, > we should set 0 for reference count for the corresponding Mac index. > Fixes a bug where removing Mac from the table still left that entry as > invalid. This fixes my problems with MTU settings with old FW. Tested-by: Roland Dreier <roland@purestorage.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Roland Dreier <roland@kernel.org> Date: Thu, 4 Aug 2011 05:55:39 -0700 >> For older FW versions, when a Mac address removed from Mac table, >> we should set 0 for reference count for the corresponding Mac index. >> Fixes a bug where removing Mac from the table still left that entry as >> invalid. > > This fixes my problems with MTU settings with old FW. > > Tested-by: Roland Dreier <roland@purestorage.com> Applied, thanks everyone. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/mlx4/port.c b/drivers/net/mlx4/port.c index 1f95afd..609e0ec 100644 --- a/drivers/net/mlx4/port.c +++ b/drivers/net/mlx4/port.c @@ -258,9 +258,12 @@ void mlx4_unregister_mac(struct mlx4_dev *dev, u8 port, int qpn) if (validate_index(dev, table, index)) goto out; - table->entries[index] = 0; - mlx4_set_port_mac_table(dev, port, table->entries); - --table->total; + /* Check whether this address has reference count */ + if (!(--table->refs[index])) { + table->entries[index] = 0; + mlx4_set_port_mac_table(dev, port, table->entries); + --table->total; + } out: mutex_unlock(&table->mutex); }
For older FW versions, when a Mac address removed from Mac table, we should set 0 for reference count for the corresponding Mac index. Fixes a bug where removing Mac from the table still left that entry as invalid. Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il> --- drivers/net/mlx4/port.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-)