Patchwork scsi-bus: use DO_UPCAST.

login
register
mail settings
Submitter Zhi Yong Wu
Date Aug. 4, 2011, 7:40 a.m.
Message ID <1312443635-21856-1-git-send-email-wuzhy@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/108359/
State New
Headers show

Comments

Zhi Yong Wu - Aug. 4, 2011, 7:40 a.m.
Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
---
 hw/scsi-bus.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Markus Armbruster - Aug. 4, 2011, 8:14 a.m.
Zhi Yong Wu <wuzhy@linux.vnet.ibm.com> writes:

> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
>  hw/scsi-bus.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
> index ad6a730..f6c416e 100644
> --- a/hw/scsi-bus.c
> +++ b/hw/scsi-bus.c
> @@ -712,7 +712,7 @@ void scsi_device_purge_requests(SCSIDevice *sdev)
>  
>  static char *scsibus_get_fw_dev_path(DeviceState *dev)
>  {
> -    SCSIDevice *d = (SCSIDevice*)dev;
> +    SCSIDevice *d = DO_UPCAST(SCSIDevice, qdev, dev);
>      SCSIBus *bus = scsi_bus_from_device(d);
>      char path[100];
>      int i;

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Stefan Hajnoczi - Aug. 4, 2011, 9:12 a.m.
On Thu, Aug 04, 2011 at 03:40:35PM +0800, Zhi Yong Wu wrote:
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
>  hw/scsi-bus.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches-next

Stefan

Patch

diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index ad6a730..f6c416e 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -712,7 +712,7 @@  void scsi_device_purge_requests(SCSIDevice *sdev)
 
 static char *scsibus_get_fw_dev_path(DeviceState *dev)
 {
-    SCSIDevice *d = (SCSIDevice*)dev;
+    SCSIDevice *d = DO_UPCAST(SCSIDevice, qdev, dev);
     SCSIBus *bus = scsi_bus_from_device(d);
     char path[100];
     int i;