[04/14] mtd: rawnand: gpmi: remove unused variable

Message ID	20190409113421.3037-5-s.hauer@pengutronix.de
State	Changes Requested
Delegated to:	Miquel Raynal
Headers	show Return-Path: <linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org> From: Sascha Hauer <s.hauer@pengutronix.de> To: linux-mtd@lists.infradead.org Subject: [PATCH 04/14] mtd: rawnand: gpmi: remove unused variable Date: Tue, 9 Apr 2019 13:34:11 +0200 Message-Id: <20190409113421.3037-5-s.hauer@pengutronix.de> In-Reply-To: <20190409113421.3037-1-s.hauer@pengutronix.de> References: <20190409113421.3037-1-s.hauer@pengutronix.de> MIME-Version: 1.0 summary: Content analysis details: (-0.0 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:67c:670:201:290:27ff:fe1d:cc33 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record Precedence: list Cc: kernel@pengutronix.de, Boris Brezillon <bbrezillon@kernel.org>, Richard Weinberger <richard@nod.at>, Sascha Hauer <s.hauer@pengutronix.de>, Vinod Koul <vkoul@kernel.org>, NXP Linux Team <linux-imx@nxp.com>, Fabio Estevam <festevam@gmail.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Han Xu <han.xu@nxp.com>, Shawn Guo <shawnguo@kernel.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org> Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org
Series	Implement exec_op for GPMI nand driver \| expand [v2,00/14] Implement exec_op for GPMI nand driver [01/14] mtd: rawnand: export nand operation tracer [02/14] mtd: rawnand: fsmc: Use nand_op_trace for operation tracing [03/14] mtd: rawnand: gpmi: move all driver code into single file [04/14] mtd: rawnand: gpmi: remove unused variable [05/14] mtd: rawnand: gpmi: Remove unnecessary variables [06/14] mtd: rawnand: gpmi: read buf in nand_read_page_op [07/14] mtd: rawnand: gpmi: remove unused parameters [08/14] mtd: rawnand: gpmi: Drop unnecessary restoring of previous chipselection [09/14] mtd: rawnand: gpmi: use runtime PM to manage clocks [10/14] dma: mxs: Drop unnecessary flag [11/14] mtd: rawnand: gpmi: drop unnecessary flag [12/14] dma: mxs: Add header file to be shared with gpmi nand driver [13/14] dma: mxs: rename custom flag [14/14] mtd: rawnand: gpmi: Implement exec_op

Message ID

20190409113421.3037-5-s.hauer@pengutronix.de

State

Changes Requested

Delegated to:

Miquel Raynal

Headers

From: Sascha Hauer <s.hauer@pengutronix.de>
To: linux-mtd@lists.infradead.org
Subject: [PATCH 04/14] mtd: rawnand: gpmi: remove unused variable
Date: Tue,  9 Apr 2019 13:34:11 +0200
Message-Id: <20190409113421.3037-5-s.hauer@pengutronix.de>
In-Reply-To: <20190409113421.3037-1-s.hauer@pengutronix.de>
References: <20190409113421.3037-1-s.hauer@pengutronix.de>
MIME-Version: 1.0
Precedence: list
Cc: kernel@pengutronix.de, Boris Brezillon <bbrezillon@kernel.org>,
	Richard Weinberger <richard@nod.at>,
	Sascha Hauer <s.hauer@pengutronix.de>, 
	Vinod Koul <vkoul@kernel.org>, NXP Linux Team <linux-imx@nxp.com>,
	Fabio Estevam <festevam@gmail.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>, 
	Han Xu <han.xu@nxp.com>, Shawn Guo <shawnguo@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "linux-mtd" <linux-mtd-bounces@lists.infradead.org>
Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org

Series

Implement exec_op for GPMI nand driver | expand

Comments

Miquel Raynal April 17, 2019, 10:24 a.m. UTC | #1

Hi Sascha,

Sascha Hauer <s.hauer@pengutronix.de> wrote on Tue,  9 Apr 2019
13:34:11 +0200:

> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---

Missing commit log (even if the patch is trivial...)

With the missing commit message:

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

>  drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h
> index e6b588c77f2f..5cd54c3a65dc 100644
> --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h
> +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h
> @@ -154,9 +154,6 @@ struct gpmi_nand_data {
>  #define DMA_CHANS		8
>  	struct dma_chan		*dma_chans[DMA_CHANS];
>  	struct completion	dma_done;
> -
> -	/* private */
> -	void			*private;
>  };
>  
>  /* BCH : Status Block Completion Codes */




Thanks,
Miquèl

diff --git a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h
index e6b588c77f2f..5cd54c3a65dc 100644
--- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h
+++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.h
@@ -154,9 +154,6 @@  struct gpmi_nand_data {
 #define DMA_CHANS		8
 	struct dma_chan		*dma_chans[DMA_CHANS];
 	struct completion	dma_done;
-
-	/* private */
-	void			*private;
 };
 
 /* BCH : Status Block Completion Codes */

[04/14] mtd: rawnand: gpmi: remove unused variable

Commit Message

Comments

Patch