[1/1] ARM: dts: imx6sx: select rgmii-id phy mode
diff mbox series

Message ID 1554781105-3514-1-git-send-email-fugang.duan@nxp.com
State Superseded
Headers show
Series
  • [1/1] ARM: dts: imx6sx: select rgmii-id phy mode
Related show

Checks

Context Check Description
robh/checkpatch warning "total: 0 errors, 1 warnings, 16 lines checked"

Commit Message

Andy Duan April 9, 2019, 3:39 a.m. UTC
The PHY AR8031 must add both tx and rx delay. But PHY driver
disable tx/rx delay by default in Commit 6d4cd041f0af(net: phy:
at803x: disable delay only for RGMII mode), which brokes i.MX6SX
sdb board networking.

So enable rgmii-txid phy mode to enable the tx/rx delay.

Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
---
 arch/arm/boot/dts/imx6sx-sdb.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Shawn Guo April 11, 2019, 7:07 a.m. UTC | #1
On Tue, Apr 09, 2019 at 03:39:18AM +0000, Andy Duan wrote:
> The PHY AR8031 must add both tx and rx delay. But PHY driver
> disable tx/rx delay by default in Commit 6d4cd041f0af(net: phy:
> at803x: disable delay only for RGMII mode), which brokes i.MX6SX
> sdb board networking.
> 
> So enable rgmii-txid phy mode to enable the tx/rx delay.
> 
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>

We already queued a patch from Fabio [1] that covers imx6sx-sdb.

Shawn

[1] https://patchwork.kernel.org/patch/10884569/

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/imx6sx-sdb.dtsi b/arch/arm/boot/dts/imx6sx-sdb.dtsi
index 08ede56..865528b 100644
--- a/arch/arm/boot/dts/imx6sx-sdb.dtsi
+++ b/arch/arm/boot/dts/imx6sx-sdb.dtsi
@@ -191,7 +191,7 @@ 
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet1>;
 	phy-supply = <&reg_enet_3v3>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy1>;
 	phy-reset-gpios = <&gpio2 7 GPIO_ACTIVE_LOW>;
 	status = "okay";
@@ -213,7 +213,7 @@ 
 &fec2 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet2>;
-	phy-mode = "rgmii";
+	phy-mode = "rgmii-id";
 	phy-handle = <&ethphy2>;
 	status = "okay";
 };