diff mbox series

mtd: rawnand: marvell: Fix helper name in comment

Message ID 20190408092849.23478-1-miquel.raynal@bootlin.com
State Accepted
Delegated to: Miquel Raynal
Headers show
Series mtd: rawnand: marvell: Fix helper name in comment | expand

Commit Message

Miquel Raynal April 8, 2019, 9:28 a.m. UTC
Since the migration of the driver to stop using the legacy
->select_chip() hook, the marvell_nfc_select_chip() helper has been
'renamed' to marvell_nfc_select_target(). Update a left-over reference
to this helper in a comment in the ->resume() path.

Fixes: b25251414f6e00 ("mtd: rawnand: marvell: Stop implementing ->select_chip()")
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 drivers/mtd/nand/raw/marvell_nand.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Boris Brezillon April 14, 2019, 8:49 a.m. UTC | #1
On Mon,  8 Apr 2019 11:28:49 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> Since the migration of the driver to stop using the legacy
> ->select_chip() hook, the marvell_nfc_select_chip() helper has been  
> 'renamed' to marvell_nfc_select_target(). Update a left-over reference
> to this helper in a comment in the ->resume() path.
> 
> Fixes: b25251414f6e00 ("mtd: rawnand: marvell: Stop implementing ->select_chip()")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  drivers/mtd/nand/raw/marvell_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
> index d984538980e2..6796c7015d86 100644
> --- a/drivers/mtd/nand/raw/marvell_nand.c
> +++ b/drivers/mtd/nand/raw/marvell_nand.c
> @@ -2989,7 +2989,7 @@ static int __maybe_unused marvell_nfc_resume(struct device *dev)
>  
>  	/*
>  	 * Reset nfc->selected_chip so the next command will cause the timing
> -	 * registers to be restored in marvell_nfc_select_chip().
> +	 * registers to be restored in marvell_nfc_select_target().
>  	 */
>  	nfc->selected_chip = NULL;
>
Miquel Raynal April 18, 2019, 4:19 p.m. UTC | #2
Hello,

Miquel Raynal <miquel.raynal@bootlin.com> wrote on Mon,  8 Apr 2019
11:28:49 +0200:

> Since the migration of the driver to stop using the legacy
> ->select_chip() hook, the marvell_nfc_select_chip() helper has been  
> 'renamed' to marvell_nfc_select_target(). Update a left-over reference
> to this helper in a comment in the ->resume() path.
> 
> Fixes: b25251414f6e00 ("mtd: rawnand: marvell: Stop implementing ->select_chip()")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  drivers/mtd/nand/raw/marvell_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
> index d984538980e2..6796c7015d86 100644
> --- a/drivers/mtd/nand/raw/marvell_nand.c
> +++ b/drivers/mtd/nand/raw/marvell_nand.c
> @@ -2989,7 +2989,7 @@ static int __maybe_unused marvell_nfc_resume(struct device *dev)
>  
>  	/*
>  	 * Reset nfc->selected_chip so the next command will cause the timing
> -	 * registers to be restored in marvell_nfc_select_chip().
> +	 * registers to be restored in marvell_nfc_select_target().
>  	 */
>  	nfc->selected_chip = NULL;
>  


Applied to 
https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git 
branch nand/next.

Thanks,
Miquèl
diff mbox series

Patch

diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
index d984538980e2..6796c7015d86 100644
--- a/drivers/mtd/nand/raw/marvell_nand.c
+++ b/drivers/mtd/nand/raw/marvell_nand.c
@@ -2989,7 +2989,7 @@  static int __maybe_unused marvell_nfc_resume(struct device *dev)
 
 	/*
 	 * Reset nfc->selected_chip so the next command will cause the timing
-	 * registers to be restored in marvell_nfc_select_chip().
+	 * registers to be restored in marvell_nfc_select_target().
 	 */
 	nfc->selected_chip = NULL;