From patchwork Wed Aug 3 08:49:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 108069 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 23F8AB71E0 for ; Wed, 3 Aug 2011 19:19:45 +1000 (EST) Received: from localhost ([::1]:54484 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoX9u-00088U-3v for incoming@patchwork.ozlabs.org; Wed, 03 Aug 2011 04:50:34 -0400 Received: from eggs.gnu.org ([140.186.70.92]:44667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoX95-0005rD-50 for qemu-devel@nongnu.org; Wed, 03 Aug 2011 04:49:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QoX8x-0003ib-Qc for qemu-devel@nongnu.org; Wed, 03 Aug 2011 04:49:37 -0400 Received: from mail-ww0-f53.google.com ([74.125.82.53]:64312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QoX8x-0003iJ-DI for qemu-devel@nongnu.org; Wed, 03 Aug 2011 04:49:35 -0400 Received: by wwf26 with SMTP id 26so527790wwf.10 for ; Wed, 03 Aug 2011 01:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:from:to:subject:date:message-id:x-mailer:in-reply-to :references; bh=Yv6gfY859+9+dUKqT19LrTKwWgDot3jqD1618jmbST8=; b=qAmyh8TJzEpqZ8xZQFfJOxjjszPVx26q9zQR3hn1t0nDpUSrYke3eidapwAL1Qmdnr tJ85vNlFwl6SPZC12LCBQA2RBLeTZgkPpC3RgQ1wS1g6mLktNAxLMfkXbF3EhFbIdzMp jN6RnlymZoOeo3tLeAAVjepaFrXRoomoi9z6E= Received: by 10.227.11.134 with SMTP id t6mr8193730wbt.21.1312361374709; Wed, 03 Aug 2011 01:49:34 -0700 (PDT) Received: from localhost.localdomain (93-34-199-31.ip51.fastwebnet.it [93.34.199.31]) by mx.google.com with ESMTPS id ff6sm485877wbb.66.2011.08.03.01.49.34 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 03 Aug 2011 01:49:34 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Wed, 3 Aug 2011 10:49:13 +0200 Message-Id: <1312361359-15445-11-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.7.6 In-Reply-To: <1312361359-15445-1-git-send-email-pbonzini@redhat.com> References: <1312361359-15445-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.53 Subject: [Qemu-devel] [PATCH 10/16] scsi: move request parsing to common code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Also introduce the first occurrence of "independent" SCSIReqOps, to handle invalid commands in common code. Signed-off-by: Paolo Bonzini --- hw/scsi-bus.c | 53 ++++++++++++++++++++++++++++++++++++++--------------- hw/scsi-disk.c | 5 ----- hw/scsi-generic.c | 9 --------- hw/scsi.h | 1 - 4 files changed, 38 insertions(+), 30 deletions(-) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index 07d8704..01dbe02 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -7,6 +7,7 @@ #include "trace.h" static char *scsibus_get_fw_dev_path(DeviceState *dev); +static int scsi_req_parse(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf); static int scsi_build_sense(uint8_t *in_buf, int in_len, uint8_t *buf, int len, bool fixed); @@ -134,6 +135,20 @@ int scsi_bus_legacy_handle_cmdline(SCSIBus *bus) return res; } +/* SCSIReqOps implementation for invalid commands. */ + +static int32_t scsi_invalid_command(SCSIRequest *req, uint8_t *buf) +{ + scsi_req_build_sense(req, SENSE_CODE(INVALID_OPCODE)); + scsi_req_complete(req, CHECK_CONDITION); + return 0; +} + +struct SCSIReqOps reqops_invalid_opcode = { + .size = sizeof(SCSIRequest), + .send_command = scsi_invalid_command +}; + SCSIRequest *scsi_req_alloc(SCSIReqOps *reqops, SCSIDevice *d, uint32_t tag, uint32_t lun, void *hba_private) { @@ -157,8 +172,22 @@ SCSIRequest *scsi_req_new(SCSIDevice *d, uint32_t tag, uint32_t lun, uint8_t *buf, void *hba_private) { SCSIRequest *req; - req = d->info->alloc_req(d, tag, lun, hba_private); - memcpy(req->cmd.buf, buf, 16); + SCSICommand cmd; + + if (scsi_req_parse(&cmd, d, buf) != 0) { + trace_scsi_req_parse_bad(d->id, lun, tag, buf[0]); + req = scsi_req_alloc(&reqops_invalid_opcode, d, tag, lun, hba_private); + } else { + trace_scsi_req_parsed(d->id, lun, tag, buf[0], + cmd.mode, cmd.xfer); + if (req->cmd.lba != -1) { + trace_scsi_req_parsed_lba(d->id, lun, tag, buf[0], + cmd.lba); + } + req = d->info->alloc_req(d, tag, lun, hba_private); + } + + req->cmd = cmd; return req; } @@ -426,27 +455,21 @@ static uint64_t scsi_cmd_lba(SCSICommand *cmd) return lba; } -int scsi_req_parse(SCSIRequest *req, uint8_t *buf) +int scsi_req_parse(SCSICommand *cmd, SCSIDevice *dev, uint8_t *buf) { int rc; - if (req->dev->type == TYPE_TAPE) { - rc = scsi_req_stream_length(&req->cmd, req->dev, buf); + if (dev->type == TYPE_TAPE) { + rc = scsi_req_stream_length(cmd, dev, buf); } else { - rc = scsi_req_length(&req->cmd, req->dev, buf); + rc = scsi_req_length(cmd, dev, buf); } if (rc != 0) return rc; - assert(buf == req->cmd.buf); - scsi_cmd_xfer_mode(&req->cmd); - req->cmd.lba = scsi_cmd_lba(&req->cmd); - trace_scsi_req_parsed(req->dev->id, req->lun, req->tag, buf[0], - req->cmd.mode, req->cmd.xfer); - if (req->cmd.lba != -1) { - trace_scsi_req_parsed_lba(req->dev->id, req->lun, req->tag, buf[0], - req->cmd.lba); - } + memcpy(cmd->buf, buf, cmd->len); + scsi_cmd_xfer_mode(cmd); + cmd->lba = scsi_cmd_lba(cmd); return 0; } diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index ceb0e0a..64aa141 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -974,11 +974,6 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t *buf) outbuf = (uint8_t *)r->iov.iov_base; DPRINTF("Command: lun=%d tag=0x%x data=0x%02x", req->lun, req->tag, buf[0]); - if (scsi_req_parse(&r->req, buf) != 0) { - BADF("Unsupported command length, command %x\n", command); - scsi_check_condition(r, SENSE_CODE(INVALID_OPCODE)); - return 0; - } #ifdef DEBUG_SCSI { int i; diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c index 699831a..e91c32e 100644 --- a/hw/scsi-generic.c +++ b/hw/scsi-generic.c @@ -84,10 +84,6 @@ static void scsi_command_complete(void *opaque, int ret) case -EDOM: status = TASK_SET_FULL; break; - case -EINVAL: - status = CHECK_CONDITION; - scsi_req_build_sense(&r->req, SENSE_CODE(INVALID_FIELD)); - break; case -ENOMEM: status = CHECK_CONDITION; scsi_req_build_sense(&r->req, SENSE_CODE(TARGET_FAILURE)); @@ -298,11 +294,6 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t *cmd) return 0; } - if (-1 == scsi_req_parse(&r->req, cmd)) { - BADF("Unsupported command length, command %x\n", cmd[0]); - scsi_command_complete(r, -EINVAL); - return 0; - } scsi_req_fixup(&r->req); DPRINTF("Command: lun=%d tag=0x%x len %zd data=0x%02x", lun, tag, diff --git a/hw/scsi.h b/hw/scsi.h index 5a1bbe2..dec814a 100644 --- a/hw/scsi.h +++ b/hw/scsi.h @@ -165,7 +165,6 @@ SCSIRequest *scsi_req_ref(SCSIRequest *req); void scsi_req_unref(SCSIRequest *req); void scsi_req_build_sense(SCSIRequest *req, SCSISense sense); -int scsi_req_parse(SCSIRequest *req, uint8_t *buf); void scsi_req_print(SCSIRequest *req); void scsi_req_continue(SCSIRequest *req); void scsi_req_data(SCSIRequest *req, int len);