Patchwork [Fortran] Allocatable coarrays: Pass "token" to caf_registering

login
register
mail settings
Submitter Tobias Burnus
Date Aug. 2, 2011, 3:47 p.m.
Message ID <4E381C19.3020003@net-b.de>
Download mbox | patch
Permalink /patch/107963/
State New
Headers show

Comments

Tobias Burnus - Aug. 2, 2011, 3:47 p.m.
Simple patch: Coarrays are identified by a token; this patch passes the 
token (which is stored in the descriptor allocatable coarrays) to 
libcaf's registering function.

In terms of token and allocatable coarrays: The next step is to fix 
passing actual arguments to assumed-shape coarrays dummies. (Explicit 
shape and deferred shape is OK.) And handling the explicit and automatic 
deallocation of allocatable coarrays.

Build and regtested on x86-64-linux.
OK for the trunk?

Tobias
Mikael Morin - Aug. 2, 2011, 4:24 p.m.
On Tuesday 02 August 2011 17:47:37 Tobias Burnus wrote:
> Simple patch: Coarrays are identified by a token; this patch passes the
> token (which is stored in the descriptor allocatable coarrays) to
> libcaf's registering function.
> 
> In terms of token and allocatable coarrays: The next step is to fix
> passing actual arguments to assumed-shape coarrays dummies. (Explicit
> shape and deferred shape is OK.) And handling the explicit and automatic
> deallocation of allocatable coarrays.
> 
> Build and regtested on x86-64-linux.
> OK for the trunk?
> 
> Tobias
> 
>   2011-08-02  Tobias Burnus  <burnus@net-b.de>
> 
[...]
>         * trans.c (gfc_allocate_using_lib): Make static, 

This is missing in the patch; OK once it is fixed. 
Thanks

Mikael

Patch

2011-08-02  Tobias Burnus  <burnus@net-b.de>

	* trans-array.c (gfc_array_allocate): Pass token to
	  gfc_allocate_allocatable for -fcoarray=lib.
	* trans-stmt.c (gfc_trans_allocate): Update
	gfc_allocate_allocatable call.
	* trans.h (gfc_allocate_allocatable): Update prototype.
	(gfc_allocate_using_lib): Remove.
	* trans.c (gfc_allocate_using_lib): Make static, handle
	token.
	(gfc_allocate_allocatable): Ditto.
	
diff --git a/gcc/fortran/trans-array.c b/gcc/fortran/trans-array.c
index dc8fdb8..a151c56 100644
--- a/gcc/fortran/trans-array.c
+++ b/gcc/fortran/trans-array.c
@@ -4409,6 +4409,7 @@  gfc_array_allocate (gfc_se * se, gfc_expr * expr, tree status, tree errmsg,
   tree tmp;
   tree pointer;
   tree offset = NULL_TREE;
+  tree token = NULL_TREE;
   tree size;
   tree msg;
   tree error = NULL_TREE;
@@ -4521,9 +4522,13 @@  gfc_array_allocate (gfc_se * se, gfc_expr * expr, tree status, tree errmsg,
   pointer = gfc_conv_descriptor_data_get (se->expr);
   STRIP_NOPS (pointer);
 
+  if (coarray && gfc_option.coarray == GFC_FCOARRAY_LIB)
+    token = gfc_build_addr_expr (NULL_TREE,
+				 gfc_conv_descriptor_token (se->expr));
+
   /* The allocatable variant takes the old pointer as first argument.  */
   if (allocatable)
-    gfc_allocate_allocatable (&elseblock, pointer, size,
+    gfc_allocate_allocatable (&elseblock, pointer, size, token,
 			      status, errmsg, errlen, expr);
   else
     gfc_allocate_using_malloc (&elseblock, pointer, size, status);
diff --git a/gcc/fortran/trans-stmt.c b/gcc/fortran/trans-stmt.c
index defa445..a911a5b 100644
--- a/gcc/fortran/trans-stmt.c
+++ b/gcc/fortran/trans-stmt.c
@@ -4867,7 +4867,7 @@  gfc_trans_allocate (gfc_code * code)
 
 	  /* Allocate - for non-pointers with re-alloc checking.  */
 	  if (gfc_expr_attr (expr).allocatable)
-	    gfc_allocate_allocatable (&se.pre, se.expr, memsz,
+	    gfc_allocate_allocatable (&se.pre, se.expr, memsz, NULL_TREE,
 				      stat, errmsg, errlen, expr);
 	  else
 	    gfc_allocate_using_malloc (&se.pre, se.expr, memsz, stat);
diff --git a/gcc/fortran/trans.c b/gcc/fortran/trans.c
index 2f8c7fd..e313803 100644
--- a/gcc/fortran/trans.c
+++ b/gcc/fortran/trans.c
@@ -635,19 +635,21 @@  gfc_allocate_using_malloc (stmtblock_t * block, tree pointer,
    This function follows the following pseudo-code:
 
     void *
-    allocate (size_t size, integer_type stat)
+    allocate (size_t size, void** token, int *stat, char* errmsg, int errlen)
     {
       void *newmem;
-    
-      newmem = _caf_register ( size, regtype, NULL, &stat, NULL, NULL);
+
+      newmem = _caf_register (size, regtype, token, &stat, errmsg, errlen);
       return newmem;
     }  */
 void
 gfc_allocate_using_lib (stmtblock_t * block, tree pointer, tree size,
-			tree status, tree errmsg, tree errlen)
+			tree token, tree status, tree errmsg, tree errlen)
 {
   tree tmp, pstat;
 
+  gcc_assert (token != NULL_TREE);
+
   /* Evaluate size only once, and make sure it has the right type.  */
   size = gfc_evaluate_now (size, block);
   if (TREE_TYPE (size) != TREE_TYPE (size_type_node))
@@ -673,8 +675,7 @@  gfc_allocate_using_lib (stmtblock_t * block, tree pointer, tree size,
 			      build_int_cst (size_type_node, 1)),
 	     build_int_cst (integer_type_node,
 			    GFC_CAF_COARRAY_ALLOC),
-	     null_pointer_node,  /* token  */
-	     pstat, errmsg, errlen);
+	     token, pstat, errmsg, errlen);
 
   tmp = fold_build2_loc (input_location, MODIFY_EXPR,
 			 TREE_TYPE (pointer), pointer,
@@ -706,8 +707,8 @@  gfc_allocate_using_lib (stmtblock_t * block, tree pointer, tree size,
     expr must be set to the original expression being allocated for its locus
     and variable name in case a runtime error has to be printed.  */
 void
-gfc_allocate_allocatable (stmtblock_t * block, tree mem, tree size, tree status,
-			  tree errmsg, tree errlen, gfc_expr* expr)
+gfc_allocate_allocatable (stmtblock_t * block, tree mem, tree size, tree token,
+			  tree status, tree errmsg, tree errlen, gfc_expr* expr)
 {
   stmtblock_t alloc_block;
   tree tmp, null_mem, alloc, error;
@@ -726,7 +727,7 @@  gfc_allocate_allocatable (stmtblock_t * block, tree mem, tree size, tree status,
 
   if (gfc_option.coarray == GFC_FCOARRAY_LIB
       && gfc_expr_attr (expr).codimension)
-    gfc_allocate_using_lib (&alloc_block, mem, size, status,
+    gfc_allocate_using_lib (&alloc_block, mem, size, token, status,
 			    errmsg, errlen);
   else
     gfc_allocate_using_malloc (&alloc_block, mem, size, status);
diff --git a/gcc/fortran/trans.h b/gcc/fortran/trans.h
index a53360f..bb94780 100644
--- a/gcc/fortran/trans.h
+++ b/gcc/fortran/trans.h
@@ -542,12 +542,11 @@  tree gfc_call_malloc (stmtblock_t *, tree, tree);
 tree gfc_build_memcpy_call (tree, tree, tree);
 
 /* Allocate memory for allocatable variables, with optional status variable.  */
-void gfc_allocate_allocatable (stmtblock_t*, tree, tree,
+void gfc_allocate_allocatable (stmtblock_t*, tree, tree, tree,
 			       tree, tree, tree, gfc_expr*);
 
 /* Allocate memory, with optional status variable.  */
 void gfc_allocate_using_malloc (stmtblock_t *, tree, tree, tree);
-void gfc_allocate_using_lib (stmtblock_t *, tree, tree, tree, tree, tree);
 
 /* Generate code to deallocate an array.  */
 tree gfc_deallocate_with_status (tree, tree, bool, gfc_expr*);
--- /dev/null	2011-08-02 08:54:55.563886097 +0200
+++ gcc/gcc/testsuite/gfortran.dg/coarray_lib_token_3.f90	2011-08-02 12:04:33.000000000 +0200
@@ -0,0 +1,13 @@ 
+! { dg-do compile }
+! { dg-options "-fcoarray=lib -fdump-tree-original" }
+!
+! Test coarray registering
+!
+integer, allocatable :: CAF(:)[:], caf_scalar[:]
+allocate(CAF(1)[*])
+allocate(CAF_SCALAR[*])
+end
+
+! { dg-final { scan-tree-dump-times "caf.data = \\(void . restrict\\) _gfortran_caf_register \\(4, 1, &caf.token, 0B, 0B, 0\\);" 1 "original" } }
+! { dg-final { scan-tree-dump-times "caf_scalar.data = \\(void . restrict\\) _gfortran_caf_register \\(4, 1, &caf_scalar.token, 0B, 0B, 0\\);" 1 "original" } }
+! { dg-final { cleanup-tree-dump "original" } }