Patchwork [BUGFIX] Fix double inversion bug in clk_disable()

login
register
mail settings
Submitter Lothar Waßmann
Date Aug. 2, 2011, 11:26 a.m.
Message ID <1312284390-20244-1-git-send-email-LW@KARO-electronics.de>
Download mbox | patch
Permalink /patch/107897/
State New
Headers show

Comments

Lothar Waßmann - Aug. 2, 2011, 11:26 a.m.
The condition check for calling the low level disable function is
wrong due to double inversion via '!' and '== 0'.

Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
 drivers/clk/clk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 83c6b67..1525e2a 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -81,7 +81,7 @@  void clk_disable(struct clk *clk)
 
 	WARN_ON(clk->enable_count == 0);
 
-	if (!--clk->enable_count == 0 && clk->ops->disable)
+	if (--clk->enable_count == 0 && clk->ops->disable)
 		clk->ops->disable(clk);
 
 	spin_unlock_irqrestore(&clk->enable_lock, flags);