From patchwork Tue Aug 2 09:16:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Toshiyuki Okajima X-Patchwork-Id: 107865 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A56C4B71C2 for ; Tue, 2 Aug 2011 19:18:09 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752758Ab1HBJSH (ORCPT ); Tue, 2 Aug 2011 05:18:07 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:47757 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752314Ab1HBJSG (ORCPT ); Tue, 2 Aug 2011 05:18:06 -0400 Received: from m2.gw.fujitsu.co.jp (unknown [10.0.50.72]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id 3EC993EE081 for ; Tue, 2 Aug 2011 18:18:06 +0900 (JST) Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id 140DB45DE82 for ; Tue, 2 Aug 2011 18:18:06 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id E446F45DE7F for ; Tue, 2 Aug 2011 18:18:05 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id D70941DB8042 for ; Tue, 2 Aug 2011 18:18:05 +0900 (JST) Received: from m107.s.css.fujitsu.com (m107.s.css.fujitsu.com [10.240.81.147]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id A1E9C1DB803A for ; Tue, 2 Aug 2011 18:18:05 +0900 (JST) Received: from m107.css.fujitsu.com (m107 [127.0.0.1]) by m107.s.css.fujitsu.com (Postfix) with ESMTP id 331A5860002; Tue, 2 Aug 2011 18:18:05 +0900 (JST) Received: from stratos (stratos.soft.fujitsu.com [10.124.101.28]) by m107.s.css.fujitsu.com (Postfix) with SMTP id B11EA6E000D; Tue, 2 Aug 2011 18:18:04 +0900 (JST) Date: Tue, 2 Aug 2011 18:16:57 +0900 From: Toshiyuki Okajima To: jack@suse.cz, akpm@linux-foundation.org, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org Subject: [PATCH v2] ext3: fix message in ext3_remount for rw-remount case Message-Id: <20110802181657.d758bd44.toshi.okajima@jp.fujitsu.com> Organization: Fujitsu co.,ltd. X-Mailer: Sylpheed 2.7.1 (GTK+ 2.12.8; i686-pc-linux-gnu) Mime-Version: 1.0 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org If there are some inodes in orphan list while a filesystem is being read-only mounted, we should recommend that pepole umount and then mount it when they try to remount with read-write. But the current message and comment recommend that they umount and then remount it. ext3_remount: /* * If we have an unprocessed orphan list hanging * around from a previously readonly bdev mount, * require a full umount/remount for now. ^^^^^^^^^^^^^^ */ if (es->s_last_orphan) { printk(KERN_WARNING "EXT3-fs: %s: couldn't " "remount RDWR because of unprocessed " "orphan inode list. Please " "umount/remount instead.\n", ^^^^^^^^^^^^^^ sb->s_id); Signed-off-by: Toshiyuki Okajima --- fs/ext3/super.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext3/super.c b/fs/ext3/super.c index 7beb69a..2043bcc 100644 --- a/fs/ext3/super.c +++ b/fs/ext3/super.c @@ -2669,13 +2669,13 @@ static int ext3_remount (struct super_block * sb, int * flags, char * data) /* * If we have an unprocessed orphan list hanging * around from a previously readonly bdev mount, - * require a full umount/remount for now. + * require a full umount & mount for now. */ if (es->s_last_orphan) { ext3_msg(sb, KERN_WARNING, "warning: couldn't " "remount RDWR because of unprocessed " "orphan inode list. Please " - "umount/remount instead."); + "umount & mount instead."); err = -EINVAL; goto restore_opts; }