Patchwork Build using CFLAGS passed in at configure

login
register
mail settings
Submitter Theodore Ts'o
Date Aug. 1, 2011, 9:58 p.m.
Message ID <1312235904-21187-1-git-send-email-tytso@mit.edu>
Download mbox | patch
Permalink /patch/107828/
State Not Applicable
Headers show

Comments

Theodore Ts'o - Aug. 1, 2011, 9:58 p.m.
In order to build xfsprogs in a hermetic build, we need be able to
pass in -I and -L flags to the compiler and linker, respectively.
This needs to be used by the configure script, but we also need to
make sure these flags are used by the Makefiles as well.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 include/builddefs.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Christoph Hellwig - Aug. 2, 2011, 10:03 a.m.
On Mon, Aug 01, 2011 at 05:58:24PM -0400, Theodore Ts'o wrote:
> In order to build xfsprogs in a hermetic build, we need be able to
> pass in -I and -L flags to the compiler and linker, respectively.
> This needs to be used by the configure script, but we also need to
> make sure these flags are used by the Makefiles as well.

Thanks a lot a Ted!

I've added this to xfsprogs, xfsdump and dmapi.  xfstests actually
already has it, sent in in 2009 by Arek for the same reason you want
it in xfsprogs.  Wish we would have been a bit better to propagate build
system fixes.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/include/builddefs.in b/include/builddefs.in
index 4c8ec64..81ebfcd 100644
--- a/include/builddefs.in
+++ b/include/builddefs.in
@@ -25,6 +25,7 @@  OPTIMIZER = @opt_build@
 MALLOCLIB = @malloc_lib@
 LOADERFLAGS = @LDFLAGS@
 LTLDFLAGS = @LDFLAGS@
+CFLAGS = @CFLAGS@
 
 LIBRT = @librt@
 LIBUUID = @libuuid@