package/dbus-python: fix build failure due to wrong auto-detected extra libs

Message ID 20190404185228.112789-1-giulio.benetti@micronovasrl.com
State New
Headers show
Series
  • package/dbus-python: fix build failure due to wrong auto-detected extra libs
Related show

Commit Message

Giulio Benetti April 4, 2019, 6:52 p.m.
Using Python 3, during configuration, if PYTHON_EXTRA_LIBS is not
defined, ./configure will launch a python script to retrieve LIBS and
SYSLIBS variables, but this is done using host-python resulting in
obtaining libraries that are not present in target. So while trying to
link configuration test it fails complaining it can't find a
library(i.e. libintl).

Set PYTHON_EXTRA_LIBS the same as PYTHON_LIBS to be sure host libs are
not used at all.

Fixes:
http://autobuild.buildroot.net/results/4078ee9e8aa304f044dc92e9345c28341349d468/

Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
 package/dbus-python/dbus-python.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Giulio Benetti April 4, 2019, 6:55 p.m. | #1
Hello all,

Il 04/04/2019 20:52, Giulio Benetti ha scritto:
> Using Python 3, during configuration, if PYTHON_EXTRA_LIBS is not
> defined, ./configure will launch a python script to retrieve LIBS and
> SYSLIBS variables, but this is done using host-python resulting in
> obtaining libraries that are not present in target. So while trying to
> link configuration test it fails complaining it can't find a
> library(i.e. libintl).
> 
> Set PYTHON_EXTRA_LIBS the same as PYTHON_LIBS to be sure host libs are
> not used at all.
> 
> Fixes:
> http://autobuild.buildroot.net/results/4078ee9e8aa304f044dc92e9345c28341349d468/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
>   package/dbus-python/dbus-python.mk | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/dbus-python/dbus-python.mk b/package/dbus-python/dbus-python.mk
> index d6af7454af..49f0de5455 100644
> --- a/package/dbus-python/dbus-python.mk
> +++ b/package/dbus-python/dbus-python.mk
> @@ -25,7 +25,8 @@ DBUS_PYTHON_DEPENDENCIES += python3 host-python3
>   DBUS_PYTHON_CONF_ENV += \
>   	PYTHON=$(HOST_DIR)/bin/python3 \
>   	PYTHON_INCLUDES="`$(STAGING_DIR)/usr/bin/python3-config --includes`" \
> -	PYTHON_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`"
> +	PYTHON_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`" \
> +	PYTHON_EXTRA_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`"
>   endif
>   
>   $(eval $(autotools-package))
> 

I'm not very happy about this solution, but I couldn't find a better one 
with my experience.

Does anyone have suggestion about it?

Thanks in advance
Thomas Petazzoni April 4, 2019, 8:51 p.m. | #2
Hello,

On Thu,  4 Apr 2019 20:52:28 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:

> Using Python 3, during configuration, if PYTHON_EXTRA_LIBS is not
> defined, ./configure will launch a python script to retrieve LIBS and
> SYSLIBS variables, but this is done using host-python resulting in
> obtaining libraries that are not present in target. So while trying to
> link configuration test it fails complaining it can't find a
> library(i.e. libintl).
> 
> Set PYTHON_EXTRA_LIBS the same as PYTHON_LIBS to be sure host libs are
> not used at all.
> 
> Fixes:
> http://autobuild.buildroot.net/results/4078ee9e8aa304f044dc92e9345c28341349d468/
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

So it started failing with the introduction of gettext-tiny ? Do we
understand why it makes a difference for dbus-python ?

Thomas

Patch

diff --git a/package/dbus-python/dbus-python.mk b/package/dbus-python/dbus-python.mk
index d6af7454af..49f0de5455 100644
--- a/package/dbus-python/dbus-python.mk
+++ b/package/dbus-python/dbus-python.mk
@@ -25,7 +25,8 @@  DBUS_PYTHON_DEPENDENCIES += python3 host-python3
 DBUS_PYTHON_CONF_ENV += \
 	PYTHON=$(HOST_DIR)/bin/python3 \
 	PYTHON_INCLUDES="`$(STAGING_DIR)/usr/bin/python3-config --includes`" \
-	PYTHON_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`"
+	PYTHON_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`" \
+	PYTHON_EXTRA_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`"
 endif
 
 $(eval $(autotools-package))