From patchwork Mon Aug 1 04:56:28 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: ext4: fix message in ext4_remount for rw-remount case Date: Sun, 31 Jul 2011 18:56:28 -0000 From: Toshiyuki Okajima X-Patchwork-Id: 107680 Message-Id: <20110801135628.3257a561.toshi.okajima@jp.fujitsu.com> To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: linux-ext4@vger.kernel.org If there are some inodes in orphan list while a filesystem is being read-only mounted, we should recommend that pepole umount and then mount it when they try to remount with read-write. But the current message/comment recommends that they umount and then remount it. ext4_remount: /* * If we have an unprocessed orphan list hanging * around from a previously readonly bdev mount, * require a full umount/remount for now. ^^^^^^^^^^^^^^ */ if (es->s_last_orphan) { ext4_msg(sb, KERN_WARNING, "Couldn't " "remount RDWR because of unprocessed " "orphan inode list. Please " "umount/remount instead"); ^^^^^^^^^^^^^^ Signed-off-by: Toshiyuki Okajima --- fs/ext4/super.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 9ea71aa..c518522 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -4390,13 +4390,13 @@ static int ext4_remount(struct super_block *sb, int *flags, char *data) /* * If we have an unprocessed orphan list hanging * around from a previously readonly bdev mount, - * require a full umount/remount for now. + * require a full umount/mount for now. */ if (es->s_last_orphan) { ext4_msg(sb, KERN_WARNING, "Couldn't " "remount RDWR because of unprocessed " "orphan inode list. Please " - "umount/remount instead"); + "umount/mount instead"); err = -EINVAL; goto restore_opts; }