Patchwork ext4: fix message in ext4_remount for rw-remount case

login
register
mail settings
Submitter Toshiyuki Okajima
Date Aug. 1, 2011, 4:56 a.m.
Message ID <20110801135628.3257a561.toshi.okajima@jp.fujitsu.com>
Download mbox | patch
Permalink /patch/107680/
State New
Headers show

Comments

Toshiyuki Okajima - Aug. 1, 2011, 4:56 a.m.
If there are some inodes in orphan list while a filesystem is being 
read-only mounted, we should recommend that pepole umount and then
mount it when they try to remount with read-write. But the current
message/comment recommends that they umount and then remount it.

ext4_remount:
	/*
	 * If we have an unprocessed orphan list hanging
	 * around from a previously readonly bdev mount,
	 * require a full umount/remount for now.
                          ^^^^^^^^^^^^^^
	 */
	if (es->s_last_orphan) {
		ext4_msg(sb, KERN_WARNING, "Couldn't "
				"remount RDWR because of unprocessed "
				"orphan inode list.  Please "
				"umount/remount instead");
                                 ^^^^^^^^^^^^^^

Signed-off-by: Toshiyuki Okajima <toshi.okajima@jp.fujitsu.com>
---
 fs/ext4/super.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Sergei Zhirikov - Aug. 6, 2011, 7:51 p.m.
On 2011-08-01 06:56, Toshiyuki Okajima wrote:
> If there are some inodes in orphan list while a filesystem is being
> read-only mounted, we should recommend that pepole umount and then
> mount it when they try to remount with read-write.
On 2011-08-01 06:56, Toshiyuki Okajima wrote:

Hi,

I have just encountered this feature and I have a question:

How do I umount/mount if it's my root filesystem?
Is there anything I can do besides "the Microsoft way" (reboot)?

--
Sergei.

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Toshiyuki Okajima - Aug. 8, 2011, 10:20 a.m.
Hi.

(2011/08/07 4:51), Sergei Zhirikov wrote:
> On 2011-08-01 06:56, Toshiyuki Okajima wrote:
>> If there are some inodes in orphan list while a filesystem is being
>> read-only mounted, we should recommend that pepole umount and then
>> mount it when they try to remount with read-write.
> On 2011-08-01 06:56, Toshiyuki Okajima wrote:
>
> Hi,
>
> I have just encountered this feature and I have a question:
>

> How do I umount/mount if it's my root filesystem?
> Is there anything I can do besides "the Microsoft way" (reboot)?
Only way that you can recover this situation by is to reboot
because the root filesystem cannot umount.

Best Regards,
Toshiyuki Okajima


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 9ea71aa..c518522 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4390,13 +4390,13 @@  static int ext4_remount(struct super_block *sb, int *flags, char *data)
 			/*
 			 * If we have an unprocessed orphan list hanging
 			 * around from a previously readonly bdev mount,
-			 * require a full umount/remount for now.
+			 * require a full umount/mount for now.
 			 */
 			if (es->s_last_orphan) {
 				ext4_msg(sb, KERN_WARNING, "Couldn't "
 				       "remount RDWR because of unprocessed "
 				       "orphan inode list.  Please "
-				       "umount/remount instead");
+				       "umount/mount instead");
 				err = -EINVAL;
 				goto restore_opts;
 			}