Patchwork [U-Boot] ARM MX31: fix clock.h: warning: function declaration isn't a prototype

login
register
mail settings
Submitter Wolfgang Denk
Date July 30, 2011, 10:37 p.m.
Message ID <1312065468-23436-1-git-send-email-wd@denx.de>
Download mbox | patch
Permalink /patch/107521/
State Superseded
Headers show

Comments

Wolfgang Denk - July 30, 2011, 10:37 p.m.
Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Albert Aribaud <albert.aribaud@free.fr>
---
 arch/arm/include/asm/arch-mx31/clock.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Fabio Estevam - July 30, 2011, 11:04 p.m.
Wolfgang,

On Sat, Jul 30, 2011 at 7:37 PM, Wolfgang Denk <wd@denx.de> wrote:
...
>  unsigned int mxc_get_clock(enum mxc_clock clk);
> -extern u32 imx_get_uartclk();
> +extern uint32_t imx_get_uartclk(void);
>  extern void mx31_gpio_mux(unsigned long mode);
>  extern void mx31_set_pad(enum iomux_pins pin, u32 config);

Stefano has already addressed this issue:
http://www.mail-archive.com/u-boot@lists.denx.de/msg57483.html

Regards,

Fabio Estevam
Wolfgang Denk - July 30, 2011, 11:35 p.m.
Dear Fabio Estevam,

In message <CAOMZO5Br55A8YO9XVO=urGF_vS3KRtHT3ooJJCMuADrFGUZZmA@mail.gmail.com> you wrote:
> 
> Stefano has already addressed this issue:
> http://www.mail-archive.com/u-boot@lists.denx.de/msg57483.html

Argh.. wasted effort then.

Thanks for pointing out.

Best regards,

Wolfgang Denk
Stefano Babic - July 31, 2011, 9:05 a.m.
On 07/31/2011 12:37 AM, Wolfgang Denk wrote:
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Albert Aribaud <albert.aribaud@free.fr>
> ---

Hi Wolfgang,

>  unsigned int mxc_get_clock(enum mxc_clock clk);
> -extern u32 imx_get_uartclk();
> +extern uint32_t imx_get_uartclk(void);
>  extern void mx31_gpio_mux(unsigned long mode);
>  extern void mx31_set_pad(enum iomux_pins pin, u32 config);

Thanks, but I have already sent the same patch a couple of days ago to
fix this issue ;-)

Best regards,
Stefano Babic

Patch

diff --git a/arch/arm/include/asm/arch-mx31/clock.h b/arch/arm/include/asm/arch-mx31/clock.h
index fb035c4..d4565ac 100644
--- a/arch/arm/include/asm/arch-mx31/clock.h
+++ b/arch/arm/include/asm/arch-mx31/clock.h
@@ -32,7 +32,7 @@  enum mxc_clock {
 };
 
 unsigned int mxc_get_clock(enum mxc_clock clk);
-extern u32 imx_get_uartclk();
+extern uint32_t imx_get_uartclk(void);
 extern void mx31_gpio_mux(unsigned long mode);
 extern void mx31_set_pad(enum iomux_pins pin, u32 config);