Patchwork [U-Boot] tqm834x.c: fix compiler warning

login
register
mail settings
Submitter Wolfgang Denk
Date July 30, 2011, 9:50 p.m.
Message ID <1312062650-24781-1-git-send-email-wd@denx.de>
Download mbox | patch
Permalink /patch/107518/
State Accepted
Commit 982db890e8ef5afa142f9519f44316086e4c2954
Delegated to: Kim Phillips
Headers show

Comments

Wolfgang Denk - July 30, 2011, 9:50 p.m.
Fix:

tqm834x.c:299: warning: passing argument 1 of 'get_ram_size' discards
qualifiers from pointer target type

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Kim Phillips <kim.phillips@freescale.com>
Cc: Kumar Gala <galak@kernel.crashing.org>
---
 board/tqc/tqm834x/tqm834x.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Kumar Gala - Aug. 1, 2011, 3:13 p.m.
On Jul 30, 2011, at 4:50 PM, Wolfgang Denk wrote:

> Fix:
> 
> tqm834x.c:299: warning: passing argument 1 of 'get_ram_size' discards
> qualifiers from pointer target type
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Kim Phillips <kim.phillips@freescale.com>
> Cc: Kumar Gala <galak@kernel.crashing.org>
> ---
> board/tqc/tqm834x/tqm834x.c |    6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)

Acked-by: Kumar Gala <galak@kernel.crashing.org>

- k
Kim Phillips - Aug. 2, 2011, 5:50 p.m.
On Mon, 1 Aug 2011 10:13:39 -0500
Kumar Gala <galak@kernel.crashing.org> wrote:

> On Jul 30, 2011, at 4:50 PM, Wolfgang Denk wrote:
> 
> > Fix:
> > 
> > tqm834x.c:299: warning: passing argument 1 of 'get_ram_size' discards
> > qualifiers from pointer target type
> > 
> > Signed-off-by: Wolfgang Denk <wd@denx.de>
> > Cc: Kim Phillips <kim.phillips@freescale.com>
> > Cc: Kumar Gala <galak@kernel.crashing.org>
> > ---
> > board/tqc/tqm834x/tqm834x.c |    6 +++---
> > 1 files changed, 3 insertions(+), 3 deletions(-)
> 
> Acked-by: Kumar Gala <galak@kernel.crashing.org>

applied.

Thanks,

Kim

Patch

diff --git a/board/tqc/tqm834x/tqm834x.c b/board/tqc/tqm834x/tqm834x.c
index 2aa97f2..260e392 100644
--- a/board/tqc/tqm834x/tqm834x.c
+++ b/board/tqc/tqm834x/tqm834x.c
@@ -59,7 +59,7 @@  ulong flash_get_size (ulong base, int banknum);
 
 /* Local functions */
 static int detect_num_flash_banks(void);
-static long int get_ddr_bank_size(short cs, volatile long *base);
+static long int get_ddr_bank_size(short cs, long *base);
 static void set_cs_bounds(short cs, long base, long size);
 static void set_cs_config(short cs, long config);
 static void set_ddr_config(void);
@@ -120,7 +120,7 @@  phys_size_t initdram (int board_type)
 		debug("\nDetecting Bank%d\n", cs);
 
 		bank_size = get_ddr_bank_size(cs,
-			(volatile long*)(CONFIG_SYS_DDR_BASE + size));
+			(long *)(CONFIG_SYS_DDR_BASE + size));
 		size += bank_size;
 
 		debug("DDR Bank%d size: %d MiB\n\n", cs, bank_size >> 20);
@@ -262,7 +262,7 @@  static int detect_num_flash_banks(void)
 /*************************************************************************
  * Detect the size of a ddr bank. Sets CS bounds and CS config accordingly.
  */
-static long int get_ddr_bank_size(short cs, volatile long *base)
+static long int get_ddr_bank_size(short cs, long *base)
 {
 	/* This array lists all valid DDR SDRAM configurations, with
 	 * Bank sizes in bytes. (Refer to Table 9-27 in the MPC8349E RM).