Patchwork [U-Boot] Fix the Double defind for setenv

login
register
mail settings
Submitter seedshope
Date July 30, 2011, 5:28 p.m.
Message ID <1312046929-10260-2-git-send-email-bocui107@gmail.com>
Download mbox | patch
Permalink /patch/107508/
State Accepted
Commit 5589073a16f8927591785a5a9e84edc292476fc1
Headers show

Comments

seedshope - July 30, 2011, 5:28 p.m.
From: seedshope <bocui107@gmail.com>

setenv is defined common.h. We do not need re-defined it

Zhong hongbo <bocui107@gmail.com>
---
 arch/arm/include/asm/u-boot-arm.h |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)
Wolfgang Denk - July 30, 2011, 8:22 p.m.
Dear Zhong Hongbo,

In message <1312046929-10260-2-git-send-email-bocui107@gmail.com> you wrote:
> From: seedshope <bocui107@gmail.com>
> 
> setenv is defined common.h. We do not need re-defined it

Thanks, but there are some more function prototypes in this block
which are actually bogus.  I have a more complete cleanup patch ready,
I'm running MAKEALL to test it right now.

Best regards,

Wolfgang Denk
Mike Frysinger - Aug. 8, 2011, 12:39 a.m.
On Saturday, July 30, 2011 13:28:49 Zhong Hongbo wrote:
> From: seedshope <bocui107@gmail.com>
> 
> setenv is defined common.h. We do not need re-defined it
> 
> Zhong hongbo <bocui107@gmail.com>

please fix your git env.  it is setting the author field to "seedshope" which 
clearly is incorrect.  it should be your name.
-mike

Patch

diff --git a/arch/arm/include/asm/u-boot-arm.h b/arch/arm/include/asm/u-boot-arm.h
index 3904027..e3fbb53 100644
--- a/arch/arm/include/asm/u-boot-arm.h
+++ b/arch/arm/include/asm/u-boot-arm.h
@@ -57,14 +57,6 @@  void	dram_init_banksize (void);
 void	setup_serial_tag (struct tag **params);
 void	setup_revision_tag (struct tag **params);
 
-/* ------------------------------------------------------------ */
-/* Here is a list of some prototypes which are incompatible to	*/
-/* the U-Boot implementation					*/
-/* To be fixed!							*/
-/* ------------------------------------------------------------ */
-/* common/cmd_nvedit.c */
-int	setenv		(char *, char *);
-
 /* cpu/.../interrupt.c */
 int	arch_interrupt_init	(void);
 void	reset_timer_masked	(void);